Use account initial as default avatar #4002
Conversation
Avatars was cutted in the top and bottom
|
The failed test seems unrelated. |
| private getColorTheme () { | ||
| const themes = { | ||
| abc: 'blue', | ||
| def: 'green', | ||
| ghi: 'purple', | ||
| jkl: 'gray', | ||
| mno: 'yellow', | ||
| pqr: 'orange', | ||
| stv: 'red', | ||
| wxyz: 'dark-blue' | ||
| } | ||
|
|
||
| const theme = Object.keys(themes).find(chars => chars.includes(this.initial)) | ||
|
|
||
| return themes[theme] | ||
| } |
There was a problem hiding this comment.
Please use a simple hash-based colour generation function, which allows more diversity even for two names beginning by the same letter.
i.e. https://stackoverflow.com/questions/3426404/create-a-hexadecimal-colour-based-on-a-string-with-javascript
There was a problem hiding this comment.
Looks nice, but how do we ensure the contrast between text and bg is good? And can it be an ugly UI if we just generate random colors?
There was a problem hiding this comment.
You can generate colors in a restricted color space.
There was a problem hiding this comment.
I'm sorry but I don't understand how this should be implemented. Shall we define a set of color spaces and match those with a text color? It sounds tricky to me. And by using color spaces I'm not confident with that the contrast between bg and text is good enough, but maybe there's an easy way to ensure that?
rigelk
added
Component: Channels
UI
client/src/app/shared/shared-account-avatar/account-avatar.component.html
Show resolved
Hide resolved
Description
Change default avatar to account name initial.
Related issues
closes #3935
Has this been tested?
Screenshots