Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder not hiding when loading data #727

Closed
jshjohnson opened this issue Oct 31, 2019 · 2 comments
Closed

Placeholder not hiding when loading data #727

jshjohnson opened this issue Oct 31, 2019 · 2 comments
Labels

Comments

@jshjohnson
Copy link
Collaborator

jshjohnson commented Oct 31, 2019

Example:
Screenshot 2019-10-31 at 12 00 59

Input types affected: select-one

Markup:

        <div data-test-hook="remote-data">
          <label for="choices-remote-data">Remote data</label>
          <select
            class="form-control"
            name="choices-remote-data"
            id="choices-remote-data"
          >
            <option value="">This is a placeholder</option>
          </select>
        </div>

JS:

        new Choices('#choices-remote-data', {
          shouldSort: false,
        }).setChoices(async () => {
          const res = await fetch('/data');
          return res.json();
        });
@jshjohnson jshjohnson added the bug label Oct 31, 2019
@tinovyatkin
Copy link
Contributor

@jshjohnson #715 will really help us with visual regressions. Do you think is related to #721 or something different?

@jshjohnson
Copy link
Collaborator Author

@jshjohnson #715 will really help us with visual regressions. Do you think is related to #721 or something different?

Yeah agreed - will review that PR now. I checked out #721 to see if it fixed the bug but it doesn't. It seems to relate to #617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants