Fix #727

[jshjohnson]

Description

Fixes the issue detailed in #727.

This removes the ability to pass a placeholder via config to select elements - the implementation was confusing and semantically it is better to pass an option element. It also removes placeholder choices from the choices list for select multiple elements.

Screenshots (if appropriate)

Types of changes

• Chore (tooling change or documentation change)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@939a73b). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #731   +/-   ##
=========================================
  Coverage          ?   66.18%           
=========================================
  Files             ?       23           
  Lines             ?     1307           
  Branches          ?        0           
=========================================
  Hits              ?      865           
  Misses            ?      442           
  Partials          ?        0

Impacted Files	Coverage Δ
src/scripts/templates.js	74.02% <ø> (ø)
src/scripts/choices.js	54.36% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 939a73b...8514ced. Read the comment docs.

[cypress]

---

Test summary

116 • 0 • 0 • 0

---

Run details

Project	Choices
Status	Passed
Commit	c0ad882
Started	Nov 2, 2019 12:23 PM
Ended	Nov 2, 2019 12:24 PM
Duration	01:20 💡
OS	Linux Ubuntu Linux - 18.04
Browser	Electron 73

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[tinovyatkin]

@jshjohnson IE is green 🎉
download the puppeteer artifact, inspect and replace it as part of this PR

[jshjohnson]

@jshjohnson IE is green 🎉
download the puppeteer artifact, inspect and replace it as part of this PR

🎉 if you can think of a better solution to 59840d1 let me know :D i've run out of free cypress recordings for the month

[tinovyatkin]

@jshjohnson IE is green 🎉
download the puppeteer artifact, inspect and replace it as part of this PR

🎉 if you can think of a better solution to 59840d1 let me know :D i've run out of free cypress recordings for the month

Sure: did you apply to https://www.cypress.io/oss-plan/ ?

[tinovyatkin]

@jshjohnson So, we are gonna have next major soon? I have a couple of breaking changes in mind...

[jshjohnson]

@jshjohnson So, we are gonna have next major soon? I have a couple of breaking changes in mind...

Unfortunately yes. Feel free!

[jshjohnson]

Sure: did you apply to https://www.cypress.io/oss-plan/ ?

I've applied now 🎈

[Fedik]

Sorry guys but the fix made the things even more confusing.

What if I want to be able to select an empty options, in multiple list?

<select multiple>
  <option value="11">Option 1</option>
  <option value="">Option 2</option>
</select>

After the fix <option value="">Option 2</option> will be considered as placeholder that is wrong.

An additionally, when I build the same with AJAX.

[jshjohnson]

What if I want to be able to select an empty options, in multiple list?

Why would you want to do that? That's the equivalent of selecting nothing 🤔

[Fedik]

That's the equivalent of selecting nothing

to select a "nothing" ;)

but it not a nothing:

<select multiple>
  <option value="11" selected>Option 1</option>
  <option value="" selected>Option 2</option>
</select>

will give you: ["11", ""] that is a "something"