[TEST] Automatic screenshots comparing and error checking in IE11, Firefox and Chrome #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinovyatkin
changed the title
tinovyatkin
changed the title
jshjohnson
reviewed
Oct 31, 2019
| await once(server, 'listening'); | ||
| return server; | ||
| } | ||
| module.exports = launchServer; |
There was a problem hiding this comment.
Is it not possible to utilise server.js? It seems to be doing the same thing
There was a problem hiding this comment.
Yes, it's possible, it just looks a little bit overblown (with WebPack middlewares and test endpoint) for me for the task. I will submit an update later.
|
@jshjohnson this is done. Test in IE11 is failing, because the actual page is failing - see #732 and #733. You can merge this first to see which PR will finally fix IE11 😄 |
|
Thanks for this! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual regressions (like #702 ) are very hard to track without automatic tools in place.
This PR adds one small GitHub Action that automatically loads demo page from local sources, opens one instance of Choices, makes screenshots in Internet Explorer 11, Firefox (on Windows and MacOs, as they are different) and Chrome (via Puppeteer) and compares them against base snapshots using pixelmatch.
If a something is not matching snapshot then a contributor will be able to download current screenshot as well as diff.
So, every PR that makes a visible changes will had to come with new snapshots making it very easy for visual review too.
On Chrome we also verifying that whole demo page is loading without errors nor
console.erroroutput.No dependencies are adding to the project itself, all required dependencies are installing on demand at GitHub Actions (I think we should do the same with
bundlesizestoo).🎉
@jshjohnson purposely didn't fixup all commits to show that it was easy 😄
PS: Had to add
.gitattributesto be able to build on WindowsPS1: Unfortunately, Safari on GitHub Actions is not configured for remote automation, so, had to left that for future improvements.