Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation #321

Merged
merged 6 commits into from
Feb 17, 2022
Merged

French translation #321

merged 6 commits into from
Feb 17, 2022

Conversation

Ilithy
Copy link
Contributor

@Ilithy Ilithy commented Jan 28, 2022

If I have made any mistakes,
please let me know,
I will make the corrections,
thank you.

@roeiedri
Copy link
Collaborator

Please update to latest strings file, sorry for the incovenience :)

@Ilithy
Copy link
Contributor Author

Ilithy commented Feb 13, 2022

Please update to latest strings file, sorry for the incovenience :)

Done, thank you for your hard work.

@roeiedri roeiedri merged commit 5cb19f7 into Chooloo:master Feb 17, 2022
@roeiedri
Copy link
Collaborator

Thank you!

@gdonisi
Copy link
Contributor

gdonisi commented Feb 18, 2022

Hi @Ilithy, you forgot to escape apostrophes in lines 57, 134, 135, 136, 173.
Also, your file is named string instead of strings, I don't know if that makes a difference (I'm an Android newbie)

@Ilithy
Copy link
Contributor Author

Ilithy commented Feb 18, 2022

@gdonisi Thank you very much, my apologies for the oversight, it is corrected on #330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants