Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compile error #527

Merged
merged 4 commits into from
Jun 19, 2023
Merged

fix compile error #527

merged 4 commits into from
Jun 19, 2023

Conversation

zhirzh
Copy link
Contributor

@zhirzh zhirzh commented May 10, 2023

this PR fixes compilation error in kontacts app

> Task :kontacts:compileDebugKotlin FAILED
kontacts/src/main/java/com/chooloo/www/kontacts/ui/contact/ContactViewState.kt:57:37 Unresolved reference: call
kontacts/src/main/java/com/chooloo/www/kontacts/ui/contact/ContactViewState.kt:64:47 Unresolved reference: call
kontacts/src/main/java/com/chooloo/www/kontacts/ui/main/MainViewState.kt:30:23 Unresolved reference: call
kontacts/src/main/java/com/chooloo/www/kontacts/ui/main/MainViewState.kt:39:30 Unresolved reference: call
kontacts/src/main/java/com/chooloo/www/kontacts/ui/quickcontact/QuickContactViewState.kt:18:30 Unresolved reference: call

the bug was added in this commit by creating mutable versions of LiveEvent and DataLiveEvent

@roeiedri roeiedri changed the base branch from master to staging June 4, 2023 20:11
@roeiedri roeiedri merged commit b6a88f3 into Chooloo:staging Jun 19, 2023
@zhirzh zhirzh deleted the fix-compile-error branch August 23, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zhirzh @roeiedri