-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fetching ALL favourite pages (not only 20) #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add coordinator for polling data feat: add translation feat: no need for local python script feat: no need docker-container feat: no manual configuration refactor: ... hm ... everything?
# Conflicts: # README.md # custom_components/tgtg/manifest.json # custom_components/tgtg/sensor.py # tgtg_get_favorites_item_id.py # tgtg_get_tokens.py
chore: remove V2 from naming
chore: remove default email in config_flow
chore: decrease log level of some outputs
… not need to be translated
fix: remove title from translations because its a brand name and does…
fix: add 500ms delay while updating item details to not flood tgtg-api (this has nothing todo with the polling interval)
…nt_tgtg # Conflicts: # custom_components/tgtg/client.py
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should solve #29
also added a slight delay of 500ms between every request of item details.
otherwise this would burst n-requests ( one for every favourite item)