Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favorites limited to 25? #29

Closed
DYLaKo opened this issue Jun 4, 2022 · 6 comments · Fixed by #70
Closed

Favorites limited to 25? #29

DYLaKo opened this issue Jun 4, 2022 · 6 comments · Fixed by #70
Labels
enhancement New feature or request upstream module All issues that are dependend of the tgtg-python module

Comments

@DYLaKo
Copy link

DYLaKo commented Jun 4, 2022

Hi,

I implemented your component yesterday, looks great. When I showed my wife, she added some more favorites to our TooGoodToGo app, which now has about 35 favorites (it was like 22).

After a reboot of HomeAssistant I see that some previous working sensors are now gone, and the amount of working sensors is 25. It looks like a hard limit, and by adding more than 25 favorites, some existing disappeared and some new do not show up.

Is the limit 25? If yes, is it possible to increase the limit?

@Chouffy
Copy link
Owner

Chouffy commented Jun 13, 2022

Hi @DYLaKo ,

I didn't coded any hard limit and I didn't tested the integration with more than 15 favorites to be honest.
Could you try to use the upstream tgtg module from your PC directly?
So we can pin-point if the issue is on the Home Assistant side of things, or on the tgtg module :)

@Chouffy Chouffy added the waiting_info Further information is requested label Jun 15, 2022
@ahivert
Copy link

ahivert commented Jun 21, 2022

the default page_size setted in tgtg package is 20 => https://github.com/ahivert/tgtg-python/blob/master/tgtg/__init__.py#L213

@DYLaKo
Copy link
Author

DYLaKo commented Jun 21, 2022

the default page_size setted in tgtg package is 20 => https://github.com/ahivert/tgtg-python/blob/master/tgtg/__init__.py#L213

I haven't had the chance yet to test, but updated the TooGoodToGo component in HomeAssistant yesterday and the active sensors are now 20, equal to above. This was 25 before?

Is it possible to increase it to a higher number by default?

@Chouffy
Copy link
Owner

Chouffy commented Jun 21, 2022

the default page_size setted in tgtg package is 20 => https://github.com/ahivert/tgtg-python/blob/master/tgtg/__init__.py#L213

Could we make it configurable when the TgtgClient is built? so then I can expose this configuration in Home Assistant
That could be something like `client = TgtgClient(email="<your_email>", page_size=50)

@Chouffy Chouffy added enhancement New feature or request upstream module All issues that are dependend of the tgtg-python module and removed waiting_info Further information is requested labels Jun 21, 2022
@tjorim tjorim linked a pull request Feb 10, 2023 that will close this issue
@tjorim tjorim added this to the 6.0.0 Rewrite with config_flow milestone Feb 24, 2023
@tjorim tjorim linked a pull request Feb 24, 2023 that will close this issue
@tjorim
Copy link
Collaborator

tjorim commented Feb 24, 2023

Will be implemented with v6.

@tjorim tjorim closed this as completed Feb 24, 2023
@Guillaumer2h
Copy link

Hello, thank you for your work! When will the v6 be available? Having more favourites would be great ! Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request upstream module All issues that are dependend of the tgtg-python module
Projects
None yet
5 participants