Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrote a requirements.txt #10

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Conversation

kettenbach-it
Copy link
Contributor

Closes #5

@Chris230291
Copy link
Owner

There is a whole bunch of stuff in there that isn't needed.
I did run the freeze command when you said so but it appeared to list every pip package I had installed ever.
I think it only works if you use virtual environments.

@Chris230291
Copy link
Owner

I just set up a virtual environment, installed the packages I listed in the readme and then 'pip list' gives...

(venv) Z:\Containers\Dockerfiles\stbproxy>pip list
Package            Version
------------------ ---------
aiofiles           0.7.0
asgiref            3.4.1
certifi            2021.5.30
charset-normalizer 2.0.4
click              8.0.1
colorama           0.4.4
fastapi            0.68.1
h11                0.12.0
idna               3.2
Jinja2             3.0.1
MarkupSafe         2.0.1
pip                19.2.3
pydantic           1.8.2
python-multipart   0.0.5
requests           2.26.0
setuptools         41.2.0
six                1.16.0
starlette          0.14.2
typing-extensions  3.10.0.2
urllib3            1.26.6
uvicorn            0.15.0

@kettenbach-it
Copy link
Contributor Author

Oh, yes.
You definitely need a virtualenv!
Without it, dependency management is not possible. With it, the dependencies are separated from the systems dependences.

If you accept this PR, there will be the requirements.txt in the repo that everyone who uses a virtual env can use

@Chris230291
Copy link
Owner

Did you see my last comment? How come our lists are very different?

@kettenbach-it
Copy link
Contributor Author

The comments have overlapped.

They are different, since I installed "pytest" and its dependencies. pytest is need for the tests that I'm working on

@Chris230291
Copy link
Owner

Ok that makes sense. I thought I had done something wrong. Do you think we should include pytest also?

@kettenbach-it
Copy link
Contributor Author

kettenbach-it commented Sep 13, 2021

If you accept this Pull-Request, then everything needed for the latest version will be in requirements.txt.

If you installed something with pip (in your virtualenv!), then update requirements.txt with "pip freeze > requirements.txt".
That is the usual workflow for working together on Python projects

@Chris230291
Copy link
Owner

OK thanks.

@Chris230291 Chris230291 merged commit 87203af into Chris230291:main Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: __init__() got an unexpected keyword argument 'allowed_methods'
2 participants