Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by Cross-Section Profile freezes, only RealChute installed KSP 1.6.0 #82

Closed
mlheur opened this issue Jan 6, 2019 · 5 comments
Closed

Comments

@mlheur
Copy link

mlheur commented Jan 6, 2019

Fresh install KSP 1.6
Downloaded and installed https://github.com/StupidChris/RealChute/releases/tag/v1.4.7.2
launch ksp
New default save
open VAB
expand advanced controls
choose filter by cross-section profile
can no longer select parts in VAB

output_log.txt

@Starwaster
Copy link
Collaborator

Confirmed. Looks like there's a nullref exception in KSP.UI.Screens.PartListCategories.BulkheadProfile.ExclusionCriteria

@mlheur
Copy link
Author

mlheur commented Jan 6, 2019

Other mods do this too, even when they are the only mod. I just reported this to KER

jrbudda/KerbalEngineer#34

@Starwaster
Copy link
Collaborator

Found the culprit. Some parts are missing bulkheadProfiles and KSP throws an exception because it's looking for that field to be populated and it isn't. I don't think this was an issue at all prior to 1.6 so something's changed on KSP's side and needs to be filed as a bug for KSP too.

@mlheur
Copy link
Author

mlheur commented Jan 7, 2019

It may be that KSP only started (mis)handling the bulkhead profile property in 1.6; but I'm doubting that they'll agree a mod-created part that's lacking some property is a bug on their end, especially since 100% of their parts have one.

Starwaster added a commit that referenced this issue Jan 27, 2019
* Added missing bulkhead field (resolves issue #82 )
@Starwaster
Copy link
Collaborator

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants