Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added pmd 6.13 support #72

Merged
merged 1 commit into from
Apr 12, 2019
Merged

added pmd 6.13 support #72

merged 1 commit into from
Apr 12, 2019

Conversation

Alexander-Krause-Glau
Copy link
Collaborator

@Alexander-Krause-Glau Alexander-Krause-Glau commented Apr 8, 2019 •
edited
Loading

Title says it all.

Can someone build the artifacts OR use the attached files (qa.eclipse.plugin.zip) and follow the local development guide to verify functionality?

@SoerenHenning ?

This was referenced Apr 8, 2019
Closed
Closed
@SoerenHenning
Copy link
Collaborator

Works perfectly in Eclipse 2019-03

@Alexander-Krause-Glau
Copy link
Collaborator Author

One more thing: Merging this will probably break PMD 5 support, since we are only publishing the latest snapshot. I don't personally care about that, but for the sake of completeness this should be denoted in this PR.

@Alexander-Krause-Glau
Copy link
Collaborator Author

Alexander-Krause-Glau commented Apr 11, 2019 •
edited
Loading

This branch is now up-to-date with the master branch and contains a clean git history. Unfortunately, I cannot test the build via mvn clean package, because it fails. Error:

Failed to execute goal org.codehaus.mojo:wagon-maven-plugin:2.0.0:upload (upload-repo) on 
project qa.eclipse.plugin.updatesite: The parameters 'url' for goal 
org.codehaus.mojo:wagon-maven-plugin:2.0.0:upload are missing or invalid

This is probably due to the change from mvn clean package to mvn clean package -s settings.xml -DupdateSiteUrl=URL -Dkeystore=KEY.

@rju rju merged commit 5ae7aeb into master Apr 12, 2019
@Alexander-Krause-Glau Alexander-Krause-Glau deleted the pmd-6-support branch April 24, 2019 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianWulf ChristianWulf Awaiting requested review from ChristianWulf

@rju rju Awaiting requested review from rju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Alexander-Krause-Glau @SoerenHenning @rju