Added PMD 6 support #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexander-Krause-Glau
force-pushed
the
master
branch
from
b9e72ba
to
680d57c
Compare
Alexander-Krause-Glau
changed the title
Closed
|
I reckon you might want to change the release version somewhere. |
|
I will have a look at it very soon. |
|
Attention: @SoerenHenning tested my generated QA-Plugin with PMD version 6.7. He used the Eclipse installer to install a new Eclipse. It seems like Eclipse versions, which have been installed with this installer, share plugin configurations. Therefore, his QA-Eclipse plugin did still use PMD version 5. A fresh "installation" via downloading and extracting the Eclipse for Java Developers did work with the instructions in #71. |
|
Closing in favor of #72 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds PMD 6 support. The plugin now uses PMD version 6.7 and updated versions of necessary dependencies.
I propose that you create a new branch
devand then apply this PR to it. Test it out and eventually merge it into master.Attention: I modified the file:
releng/pmd.eclipse.plugin.updatesite/pom.xmlas shown in #69. You might want to fix this for a release.