Unreachable State Not Caught

[mtsvickers]

If a state us unreachable it should be considered invalid ASL, but right now still validates.
Ex: ( "Finished Choice" is unreachable but this returns valid)

{
	"StartAt": "Start State",
	"States":{
		"Start State": {
			"Type": "Pass",
			"Next": "Finished"
		},
		"Finished Choice":{
			"Type":"Choice",
			"Choices": [
				{
					"Variable": "$.x",
					"BooleanEquals": false,
					"Next": "Finished"
				}
			],
			"Default": "Finished"
		},
		"Finished": {
			"Type": "Pass",
			"End": true
		}
	}
}

[ChristopheBougere]

Thanks for reporting!

You're right, this state machine definition should throw

Error code: MISSING_TRANSITION_TARGET 
Message: State "Finished Choice" is not reachable.

For now, asl-validator is validating syntax statically using JSON schemas and JSON paths.
I'd like to add this case, but we need to define a clear rule to know when a state is unreachable.
Maybe every state should be referenced either in:

• a StartAt field (of the state machine or a parallel state)
• a Next field (of a state or a catch)
• a Default field (of a choice)

Do you see anything else?

[mtsvickers]

I think that would cover everything for an unreachable state. The converse of this is if next points to a state which doesn't exist (typo in the name for example) we would want to catch that.

[ChristopheBougere]

Fixed in 1.0.8, thanks @tristanbenier

[mtsvickers]

Thank you!

…

On Wed, Apr 4, 2018 at 4:21 AM, Christophe Bougère ***@***.*** > wrote: Fixed in 1.0.8, thanks @tristanbenier <https://github.com/tristanbenier> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#17 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AgdXgQY1DhsTTmjy29VTFSE1t7LfXR8_ks5tlKyngaJpZM4SsoOU> .