-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azp: missing parameter names are not reported #237
Comments
The fix for this was merged, can we cut a new release? |
I still want to resolve this error, could be related with your change. Visible in vscode extension 0.0.4 (the current main branch)
Edit User error, the code needs to validate that the key/name of a sequence parameter is defined Most of the parser works good with working files, but some error checks are missing |
Can you provide a sample that caused the error? |
It is clearly a yaml syntax error and not any regression, so I created a new release 3.11.9 (vscode ext 0.0.4) parameters:
- parameters: val # <-- syntax error, causes a null exception and doesn't tell what is wrong, you could also just remove the `name` key
type: object
default:
- a
- b
steps:
- script: echo ${{ converttojson(parameters.val) }} May be worth to check the error in a unit test, to not be a |
That's an easy test to write. I'll open a PR |
* Improve error handling for un-named parameters #237 * added missing error handler
Consider the following
Should report an error message
A value for the 'required' parameter must be provided
No error message is reported
The text was updated successfully, but these errors were encountered: