Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump docker/build-push-action from v1 to v2 #7

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 7, 2020

Bumps docker/build-push-action from v1 to v2.

Changelog

Sourced from docker/build-push-action's changelog.

2.0.0 (2020/??/??)

v2 of Build Push action uses Docker Buildx. It's also rewritten as a typescript-action to be as closed as possible of the GitHub Runner during its execution (#71 #92).

  • Rename path input to context
  • Rename dockerfile input to file
  • Rename always_pull input to pull
  • Add builder input to be able to choose a builder instance through our setup-buildx action
  • Add platforms input
  • Add allow input
  • Add load input
  • Add outputs input
  • Add cache-from input
  • Add cache-to input
  • Add secrets input
  • Review tags input
  • Remove repository, username, password, registry, cache_froms inputs
  • Remove tag_with_sha, tag_with_ref, add_git_labels inputs
  • Handle Git context
  • Add digest output
  • Login support moved to docker/login-action repo
  • Enhanced examples in README
  • Tests and/or CI workflows

1.1.0 (2020/04/23)

  • Add cache-from support fixing #7
  • Add GCR example

1.0.1 (2020/03/23)

  • Clarify dockerfile and path inputs
  • Rename LICENCE to LICENSE
  • Use v1 of docker/gihub-actions image
  • Logs in before building image
Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 7, 2020
@markdorison
Copy link
Contributor

Updating this will require changes to our build-images.yml workflow.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 9, 2020

A newer version of docker/build-push-action exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@markdorison
Copy link
Contributor

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 9, 2020

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@markdorison markdorison force-pushed the dependabot/github_actions/docker/build-push-action-v2 branch 2 times, most recently from e07a73b to 6f6f391 Compare January 11, 2022 21:40
@markdorison markdorison force-pushed the dependabot/github_actions/docker/build-push-action-v2 branch from 6f6f391 to 082b42d Compare January 11, 2022 21:44
Copy link
Member

@agarzola agarzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this looks reasonable to me. I especially like that we (apparently) don’t have to build images twice now (once for validation, then again for publication). Leaving one question/suggestion, but otherwise this looks good to me.

.github/workflows/build-images.yml Show resolved Hide resolved
Co-authored-by: Alfonso Gómez-Arzola <alfonso@chromatichq.com>
@markdorison markdorison merged commit 4b39a75 into main Jan 12, 2022
@markdorison markdorison deleted the dependabot/github_actions/docker/build-push-action-v2 branch January 12, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants