Skip to content

Commit

Permalink
[RPP] Remove the flag that allows showing console.profile() in Perfor…
Browse files Browse the repository at this point in the history
…mance panel

Bug: 40262073
Change-Id: I93f4592f7f9cf2f4e97e041b900046d1a2794a32
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5425032
Reviewed-by: Andres Olivares <andoli@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Auto-Submit: Nancy Li <nancyly@chromium.org>
  • Loading branch information
Nancy Li authored and Devtools-frontend LUCI CQ committed Apr 4, 2024
1 parent c80bda4 commit 69a3bdf
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 9 deletions.
1 change: 0 additions & 1 deletion front_end/core/host/UserMetrics.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1042,7 +1042,6 @@ export enum DevtoolsExperiments {
'authored-deployed-grouping' = 63,
'important-dom-properties' = 64,
'just-my-code' = 65,
'timeline-as-console-profile-result-panel' = 67,
'preloading-status-panel' = 68,
'outermost-target-selector' = 71,
'highlight-errors-elements-panel' = 73,
Expand Down
1 change: 0 additions & 1 deletion front_end/core/root/Runtime.ts
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,6 @@ export const enum ExperimentName {
IMPORTANT_DOM_PROPERTIES = 'important-dom-properties',
JUST_MY_CODE = 'just-my-code',
PRELOADING_STATUS_PANEL = 'preloading-status-panel',
TIMELINE_AS_CONSOLE_PROFILE_RESULT_PANEL = 'timeline-as-console-profile-result-panel',
OUTERMOST_TARGET_SELECTOR = 'outermost-target-selector',
HIGHLIGHT_ERRORS_ELEMENTS_PANEL = 'highlight-errors-elements-panel',
SET_ALL_BREAKPOINTS_EAGERLY = 'set-all-breakpoints-eagerly',
Expand Down
4 changes: 0 additions & 4 deletions front_end/entrypoints/main/MainImpl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -286,9 +286,6 @@ export class MainImpl {
Root.Runtime.experiments.register('timeline-show-all-events', 'Timeline: show all events', true);
Root.Runtime.experiments.register(
'timeline-v8-runtime-call-stats', 'Timeline: V8 Runtime Call Stats on Timeline', true);
Root.Runtime.experiments.register(
'timeline-as-console-profile-result-panel',
'View console.profile() results in the Performance panel for Node.js', true);
Root.Runtime.experiments.register(
'timeline-track-configuration',
'Timeline: Enable track configuration feature that can reorder or hide a track in the flame chart', true);
Expand Down Expand Up @@ -402,7 +399,6 @@ export class MainImpl {
Root.Runtime.experiments.enableExperimentsByDefault([
'css-type-component-length-deprecate',
'set-all-breakpoints-eagerly',
Root.Runtime.ExperimentName.TIMELINE_AS_CONSOLE_PROFILE_RESULT_PANEL,
Root.Runtime.ExperimentName.OUTERMOST_TARGET_SELECTOR,
Root.Runtime.ExperimentName.PRELOADING_STATUS_PANEL,
'evaluate-expressions-with-source-maps',
Expand Down
2 changes: 0 additions & 2 deletions front_end/panels/timeline/TimelinePanel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,6 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod

SDK.TargetManager.TargetManager.instance().addEventListener(
SDK.TargetManager.Events.SuspendStateChanged, this.onSuspendStateChanged, this);
if (Root.Runtime.experiments.isEnabled('timeline-as-console-profile-result-panel')) {
const profilerModels = SDK.TargetManager.TargetManager.instance().models(SDK.CPUProfilerModel.CPUProfilerModel);
for (const model of profilerModels) {
for (const message of model.registeredConsoleProfileMessages) {
Expand All @@ -452,7 +451,6 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
},
},
);
}
SDK.TargetManager.TargetManager.instance().observeTargets({
targetAdded: (target: SDK.Target.Target) => {
if (target !== SDK.TargetManager.TargetManager.instance().primaryPageTarget()) {
Expand Down
1 change: 0 additions & 1 deletion front_end/testing/EnvironmentHelpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ const REGISTERED_EXPERIMENTS = [
Root.Runtime.ExperimentName.INSTRUMENTATION_BREAKPOINTS,
'css-type-component-length-deprecate',
Root.Runtime.ExperimentName.STYLES_PANE_CSS_CHANGES,
Root.Runtime.ExperimentName.TIMELINE_AS_CONSOLE_PROFILE_RESULT_PANEL,
Root.Runtime.ExperimentName.HEADER_OVERRIDES,
Root.Runtime.ExperimentName.HIGHLIGHT_ERRORS_ELEMENTS_PANEL,
Root.Runtime.ExperimentName.SET_ALL_BREAKPOINTS_EAGERLY,
Expand Down

0 comments on commit 69a3bdf

Please sign in to comment.