base install ERROR

[oberon-manjaro]

weird:

I don't understand what's going on there.
We are at

filter_packages
check_for_error "packages to install: $(cat /mnt/.base | tr '\n' ' ')"
# If at least one kernel selected, proceed with installation.
basestrap ${MOUNTPOINT} $(cat /mnt/.base) 2>$ERR
check_for_error "install basepkgs" $?

A manual cat /mnt/.base gives me a nice list of packages. Why does it say cat : ' ' : No such file or directory ?

[papajoker]

error is at line basestrap
if basestrap we hare in /mnt/ ? good path ? is :

 basestrap ${MOUNTPOINT} $(cat .base) 2>$ERR

or

 local fbase=$(</mnt/.base)
 basestrap ${MOUNTPOINT} $(fbase) 2>$ERR

[Chrysostomus]

It's because same filter packages function is used for both base installation and desktop installation. Fixed in the local branch, pushing soon

[oberon-manjaro]

Uhm. Oops, not fixed!

[oberon-manjaro]

Also, both of @papajoker 's suggestions give the same error - but funny: why packages are being intalled anyway??

[oberon-manjaro]

In fact, looking at the code again:

filter_packages
check_for_error "packages to install: $(cat /mnt/.base | tr '\n' ' ')"
# If at least one kernel selected, proceed with installation.
basestrap ${MOUNTPOINT} $(cat /mnt/.base) 2>$ERR
check_for_error "install basepkgs" $?

That error, appended in the same line as the packages... seems not to belong to check_for_error after basestrap but simply to the logging one before - so, most likely we can just forget about it.
If the error would belong to the basestrap command it would need to come after "install basepkgs", right!
I just don't understand where it comes from.
We can maybe just 2>/dev/null that first line. The output remains a mystery to me however! 😉

[oberon-manjaro]

Mystery solved! 😆
The error actually belongs to filter_packages() where at the begin we had a 2>$ERR, not followed by an error check.
So the real error here is this:

[oberon-manjaro]

The problem here is that $target_desktop hasn't been defined, yet. This will only happen in install_manjaro_de_wm()

[Chrysostomus]

I tried to make a if statement that would cat that only if /tmp/.desktop is present, but apparently it checks for it anyway...

[oberon-manjaro]

I'm almost done with a new xfce install. Filtering seems to work as it should and no error in log.
👍