Replacing Cupboard with Room #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivierperez
requested changes
Jan 31, 2019
library/src/main/java/com/readystatesoftware/chuck/api/ChuckCollector.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| val requestDateString: String? | ||
| get() = requestDate?.toString() |
There was a problem hiding this comment.
This class is an entity, it shouldn't be in charge of formatting values. Same for responseDateString, durationString, etc.
There was a problem hiding this comment.
So this can easily be removed. The problem is unfortunately wider.
So far I tried to make sure HttpTransaction.kt had a similar api with HttpTransaction.java.
I'll say we can probably refactor all this stuff outside of the data class and have it inside say FormatUtils?
I'll anyway keep those refactorings outside of this PR.
library/src/main/java/com/readystatesoftware/chuck/internal/data/entity/HttpTransaction.kt
Show resolved
Hide resolved
library/src/main/java/com/readystatesoftware/chuck/internal/data/entity/HttpTransaction.kt
Outdated
Show resolved
Hide resolved
library/src/main/java/com/readystatesoftware/chuck/internal/data/room/RecordedThrowableDao.kt
Outdated
Show resolved
Hide resolved
library/src/main/java/com/readystatesoftware/chuck/internal/data/room/RecordedThrowableDao.kt
Outdated
Show resolved
Hide resolved
library/src/main/java/com/readystatesoftware/chuck/internal/data/room/RecordedThrowableDao.kt
Outdated
Show resolved
Hide resolved
.../src/main/java/com/readystatesoftware/chuck/internal/ui/transaction/TransactionActivity.java
Outdated
Show resolved
Hide resolved
.../main/java/com/readystatesoftware/chuck/internal/ui/transaction/TransactionListFragment.java
Outdated
Show resolved
Hide resolved
olivierperez
added
the
infra
|
Hey @olivierperez so I've addressed all your comments + left a couple of questions. |
olivierperez
approved these changes
Feb 21, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took some time but I managed to remove Cupboard completely :)
Unfortunately the Pull Request is pretty big :( Let me know if I should split it somehow to make it easier to review.
Summary of changes: