Improving counting of seen transactions in notification message #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the count of transactions that is shown on the notification.
Apparently this code:
was causing a miscount of the seen HTTP calls. If a call is already
.Completed
by the time it gets reported to Chucker, thetransactionCount
variable won't be updated.I'm replacing the simple counter with an
HashSet
of transaction IDs. This will allow us to precisely count how many HTTP Request/Response we saw and report it in the notification number.Fixes #84