Fix trailing slash issues for SystemURLs::getURL()

This function will now always return a URL that does not end with a trailing slash.

Locations in the code that call this function must insert a separator slash as necessary.

Closes #5184

src/ChurchCRM/dto/SystemURLs.php

@@ -72,9 +72,15 @@ public static function getSupportURL($topic="")
 
     }
 
-  public static function getURL($index = 0)
+    public static function getURL($index = 0)
     {
-        return self::$urls[$index];
+        // Return the URL configured for this server from Include/Config.php
+        // Trim any trailing slashes from the configured URL
+        $URL = self::$urls[$index];
+        if (substr($URL,-1,1) == "/") {
+            return substr($URL,0,-1);
+        }
+        return $URL;
     }
 
     private static function isValidRootPath()

src/api/routes/people/people-family.php

@@ -95,7 +95,7 @@
         $token->build("verifyFamily", $family->getId());
         $token->save();
         $family->createTimeLineNote("verify-URL");
-        return $response->withJSON(["url" => SystemURLs::getURL() . "external/verify/" . $token->getToken()]);
+        return $response->withJSON(["url" => SystemURLs::getURL() . "/external/verify/" . $token->getToken()]);
     });
 
     $this->post('/verify/now', function ($request, $response, $args) {

src/views/email/BaseEmail.html

@@ -52,7 +52,7 @@ <h2 class="display-3">{{churchName}}</b></h2>
             {{/ userName}}
             {{# verificationToken}}
             <p>
-                <a href="{{churchCRMURL}}external/verify/{{verificationToken}}" target="_blank">{{churchCRMURL}}external/verify/{{verificationToken}}</a>
+                <a href="{{churchCRMURL}}/external/verify/{{verificationToken}}" target="_blank">{{churchCRMURL}}/external/verify/{{verificationToken}}</a>
             </p>
             {{/ verificationToken}}
             {{# passwordResetLinkURL}}