Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some gettext's with variable not working #1251

Closed
saulowulhynek opened this issue Oct 31, 2016 · 10 comments
Closed

Some gettext's with variable not working #1251

saulowulhynek opened this issue Oct 31, 2016 · 10 comments
Assignees
Milestone

Comments

@saulowulhynek
Copy link

In QueryList.php
gettext( $qry_Name ) in line 45;
gettext($qry_Description) in line 47;

And in SystemSettings.php
gettext($cfg_tooltip) in line 237 ...

This last apears in some place working, other no.

They are tranlated in messages.po

@saulowulhynek
Copy link
Author

gettext($ucfg_tooltip), in line 157 of file SettingsIndividual.php, don´t work too

@DawoudIO DawoudIO added the bug label Nov 5, 2016
@DawoudIO DawoudIO added this to the 2.4.0 milestone Nov 5, 2016
@DawoudIO
Copy link
Contributor

DawoudIO commented Nov 5, 2016

let me see if the terms are in the db or not

@saulowulhynek
Copy link
Author

They are in db.

@DawoudIO
Copy link
Contributor

DawoudIO commented Nov 7, 2016

Can you test a new install vs upgrade... Maybe test on the demo site..

@saulowulhynek
Copy link
Author

Well, I made a new install (upload the code and new db) of 2.3.1 version and the problem persists..
I tested to in Master 2.3.1 Build and Development 2.4.0 - Beta demo sites and the same occour.
As would be the upgrade test?

@DawoudIO
Copy link
Contributor

DawoudIO commented Nov 7, 2016

hmm let me see why

@saulowulhynek
Copy link
Author

In QueryList.php all work fine now in 2.3.5, but in QueryList.php, the tips for above variables is not working. The text of these tips are in POEditor.com

sMinPasswordChange
iMaxFailedLogins
sSessionTimeout
bEmailSend
bShowFamilyData
debug
sLanguage
iPDFOutputType

I tried export the terms by webinterface in POEditor.com to test if it works. That's no work.

@DawoudIO
Copy link
Contributor

QueryList.php will be fixed in 2.4.0 RC 2

@crossan007
Copy link
Contributor

I'm thinking this has to do with the carriage return characters in the translated strings..

@saulowulhynek
Copy link
Author

maybe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants