Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic DB upgrade on Restore Database may fail silently #1427

Closed
dschwen opened this issue Nov 21, 2016 · 1 comment · Fixed by #1504
Closed

Automatic DB upgrade on Restore Database may fail silently #1427

dschwen opened this issue Nov 21, 2016 · 1 comment · Fixed by #1504
Assignees
@DawoudIO
Labels
bug build
Milestone
2.4.0

Comments

@dschwen
Copy link

dschwen commented Nov 21, 2016

The db schema upgrade can fail (if MySQL strict mode is enabled for example), but will do so silently and it will even update the version_ver table.
@DawoudIO DawoudIO modified the milestone: 2.4.0 Nov 21, 2016
@DawoudIO
Copy link
Contributor

DawoudIO commented Nov 27, 2016 •
edited

now it will return

image

@DawoudIO DawoudIO added this to the 2.4.0 milestone Nov 27, 2016
DawoudIO added a commit that referenced this issue Nov 27, 2016
@DawoudIO
check for errors on query run
0d7e638 
fix #1427
@DawoudIO DawoudIO mentioned this issue Nov 27, 2016
Merged
@DawoudIO DawoudIO self-assigned this Nov 27, 2016
DawoudIO added a commit that referenced this issue Nov 29, 2016
@DawoudIO
System failure cleanup (#1472)
3fd9a7c 
* renamed mysql_failure  to system_failure

* calling system_failure  when there is no iCurrentFundraiser

#1449

* check for errors on query run

fix #1427

* better message

* revert per #1472 comments
@crossan007 crossan007 mentioned this issue Nov 30, 2016
Merged
@crossan007 crossan007 mentioned this issue Dec 3, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DawoudIO DawoudIO

Labels
bug build
Projects
None yet
Milestone
2.4.0
Development

Successfully merging a pull request may close this issue.

cleanup database migration scripts pre-release ChurchCRM/CRM
2 participants
@dschwen @DawoudIO