Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor JS directory structure needs improvement #2012

Closed
crossan007 opened this issue Feb 26, 2017 · 3 comments
Closed

Vendor JS directory structure needs improvement #2012

crossan007 opened this issue Feb 26, 2017 · 3 comments
Assignees
@DawoudIO
Labels
build development
Milestone
2.9.0

Comments

@crossan007
Copy link
Contributor

We should make a new directory for external code in our repo so we don't have to keep excluding new external projects
@crossan007 crossan007 mentioned this issue Feb 26, 2017
Merged
@DawoudIO
Copy link
Contributor

DawoudIO commented Jul 4, 2017

we tried this and @crossan007 did not like it... what is the path forward here

@crossan007 crossan007 modified the milestone: Backlog Jul 14, 2017
@crossan007
Copy link
Contributor Author

we could add all of the vendor code to the grunt concat step, and make one large js file that can be retrieved in a single include (and cached )

@crossan007
Copy link
Contributor Author

@DawoudIO I think you finished this?

@crossan007 crossan007 modified the milestones: Backlog, On-Deck Dec 4, 2017
@DawoudIO DawoudIO closed this as completed Dec 4, 2017
@crossan007 crossan007 modified the milestones: On-Deck, 2.9.0 Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DawoudIO DawoudIO

Labels
build development
Projects
None yet
Milestone
2.9.0
Development

No branches or pull requests
2 participants
@DawoudIO @crossan007