Memeber photos #154
Merged
Memeber photos #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DawoudIO
commented
Jan 2, 2016
DawoudIO
commented
- Note this is a branch off the mailchimp as it needs a few of these fixes, please review after the merge or mailchimp.
- getPhoto now return photo url not echo it
Closed
| } | ||
| } | ||
| return $photoFile; | ||
| function getPersonPhoto($personId) { |
There was a problem hiding this comment.
Rather than making this a global function, would it make more sense to instantiate the PersonService on the pages that need to reference the person objects?
There was a problem hiding this comment.
I suppose this would be a lot more work, and can't really be completed until we fully build out the API and Services, so let's just do that in a separate PR down the road.
Fix non-loading Pictures for uploaded images Fix non-loading Pictures for gravatar images
|
With the changes in 15efa9b this PR looks good. |
This was referenced Jan 25, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.