Update PersonEditor.php #3344
Update PersonEditor.php #3344
Conversation
bdadieb
commented
Nov 17, 2017
bdadieb
commented
- adding more details in person data
- adding icons to fields
There was a problem hiding this comment.
changes to the schema need to be in line with recommendations here: https://github.com/ChurchCRM/CRM/wiki/Code-Functional-Reference#changes-to-the-db-schema
|
@crossan007 thanks for your review |
| @@ -5,7 +5,12 @@ | |||
| * website : http://www.churchcrm.io | |||
| * copyright : Copyright 2001, 2002, 2003 Deane Barker, Chris Gebhardt | |||
| * Copyright 2004-2005 Michael Wilt | |||
| * | |||
| * | |||
| * ChurchCRM is free software; you can redistribute it and/or modify | |||
There was a problem hiding this comment.
we removed all of these out of the system...
There was a problem hiding this comment.
Thanks for your reviews
i was working on an elder version 👍
| $sNationalError = gettext('Entered ID is too big,<p>Please enter only the "14" Digits National ID.'); | ||
| $bErrorFlag = true; | ||
| } elseif (strlen($iNational) < 14) { | ||
| $sNationalError = gettext('You entered too small ID,<p>Please enter only the "14" Digits National ID.'); |
There was a problem hiding this comment.
no html in messages, please break into two strings... also in the US it is called Social Security Number. Since US English is the default language others can override in the locale settings.
| $sNationalError = gettext('You entered too small ID,<p>Please enter only the "14" Digits National ID.'); | ||
| $bErrorFlag = true; | ||
| } elseif (strlen($iNational) < 1) { | ||
| $sNationalError = gettext('You must enter the "14" Digits National ID.'); |
There was a problem hiding this comment.
the count of the # should be settings please see https://github.com/ChurchCRM/CRM/blob/master/src/ChurchCRM/dto/SystemConfig.php
| $sWorkplaceError = gettext('You must enter Company or Workplace.'); | ||
| $bErrorFlag = true; | ||
| } else { | ||
| $sWorkplace = $sWorkplace; |
| $sWorkError = gettext('You must enter the Job or Work description.'); | ||
| $bErrorFlag = true; | ||
| } else { | ||
| $sWork = $sWork; |
| <p/> | ||
| <div class="row"> | ||
| <div class="col-md-4"> | ||
| <label for="RecChurch"><?= gettext('Church of Recognition') ?>:</label> |
There was a problem hiding this comment.
what is the goal here... we are building a new system for having a Diocese / Parish
There was a problem hiding this comment.
great but this is not for that its for confession follow-up
also i need your help to set alert for last confession date if it overdue number of days
| </div> | ||
| </div> | ||
| <div class="col-md-3"> | ||
| <label for="RecFather"><?= gettext('Recognition Father') ?>:</label> |
There was a problem hiding this comment.
is this father of confession if so I'm working on another system for it.
| </div> | ||
| </div> | ||
| <div class="form-group col-md-3 col-lg-3"> | ||
| <label><?= gettext('Last Recognition') ?>:</label> |
| value="<?= change_date_for_place_holder($dMembershipDate) ?>" maxlength="10" id="sel1" size="11" | ||
| placeholder="<?= SystemConfig::getValue("sDatePickerPlaceHolder") ?>"> | ||
| value="<?= $dMembershipDate ?>" maxlength="10" id="sel1" size="11" | ||
| placeholder="YYYY-MM-DD"> |
There was a problem hiding this comment.
please put back the system setting as it affects how people format dates
| value="<?= change_date_for_place_holder($dFriendDate) ?>" maxlength="10" id="sel2" size="10" | ||
| placeholder="<?= SystemConfig::getValue("sDatePickerPlaceHolder") ?>"> | ||
| value="<?= $dFriendDate ?>" maxlength="10" id="sel2" size="10" | ||
| placeholder="YYYY-MM-DD"> |
ghost
assigned 
|
please fix merge issues |
|
please reopen when code is ready |
