Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phili67 calendar.php checkbox bug resolution #3630

Merged
merged 16 commits into from Dec 6, 2017
Merged

Phili67 calendar.php checkbox bug resolution #3630

merged 16 commits into from Dec 6, 2017

Conversation

phili67
Copy link

@phili67 phili67 commented Dec 5, 2017

What's this PR do?

This will solve : #3591

@ghost ghost assigned phili67 Dec 5, 2017
@ghost ghost added the In Review label Dec 5, 2017
@crossan007
Copy link
Contributor

@phili67 this still doesn't quite work as expected:

image

@ghost ghost assigned crossan007 Dec 6, 2017
crossan007
crossan007 approved these changes Dec 6, 2017
View reviewed changes
Copy link
Contributor

@crossan007 crossan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it works.

@DawoudIO DawoudIO merged commit f339e67 into master Dec 6, 2017
@ghost ghost removed the In Review label Dec 6, 2017
@DawoudIO DawoudIO deleted the phili67-calendar.php-checkbox-bug-resolution branch December 6, 2017 15:31
@DawoudIO DawoudIO added this to the 2.9.2 milestone Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crossan007 crossan007 crossan007 approved these changes

@DawoudIO DawoudIO Awaiting requested review from DawoudIO

Assignees

@crossan007 crossan007

@phili67 phili67

Labels
None yet
Projects
None yet
Milestone
2.9.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@phili67 @crossan007 @DawoudIO