Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Mark equations where black formatting should not apply #122

Merged
merged 18 commits into from
Dec 13, 2023

Conversation

ConnorStoneAstro
Copy link
Member

Black formatting is intended for OOP python, not mathematical expressions. Often the way it breaks up an equation makes it harder to read. Here we mark equations that shouldn't be formatted by Black.

@ConnorStoneAstro ConnorStoneAstro added the style Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, et label Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (40fee3e) 88.74% compared to head (71cd594) 88.83%.

Files Patch % Lines
src/caustics/lenses/base.py 33.33% 4 Missing ⚠️
src/caustics/lenses/utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #122      +/-   ##
==========================================
+ Coverage   88.74%   88.83%   +0.09%     
==========================================
  Files          36       36              
  Lines        1901     1917      +16     
==========================================
+ Hits         1687     1703      +16     
  Misses        214      214              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lsetiawan
Copy link
Collaborator

Let's wait until #124 is merged to merge this one.

Copy link
Collaborator

@lsetiawan lsetiawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Collaborator

@AlexandreAdam AlexandreAdam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've flagged 3 equations which I think are too long and deserve to be simplified in the code. The rest looks good to me.

src/caustics/cosmology.py Outdated Show resolved Hide resolved
src/caustics/lenses/pseudo_jaffe.py Outdated Show resolved Hide resolved
src/caustics/lenses/pseudo_jaffe.py Outdated Show resolved Hide resolved
@ConnorStoneAstro ConnorStoneAstro merged commit 46f125b into dev Dec 13, 2023
13 checks passed
@ConnorStoneAstro ConnorStoneAstro deleted the equnofmt branch December 13, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
style Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, et
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants