Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor dtype fixes for forward raytrace, add x0, y0 to LensSource #234

Merged
merged 6 commits into from
Jul 5, 2024

Conversation

ConnorStoneAstro
Copy link
Member

No description provided.

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.19%. Comparing base (6ce2497) to head (31e5140).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #234      +/-   ##
==========================================
+ Coverage   93.17%   93.19%   +0.01%     
==========================================
  Files          59       59              
  Lines        2726     2732       +6     
==========================================
+ Hits         2540     2546       +6     
  Misses        186      186              
Flag Coverage Δ
unittests 93.19% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@AlexandreAdam AlexandreAdam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look good, just some naming issue and it's good to go

src/caustics/lenses/func/base.py Outdated Show resolved Hide resolved
src/caustics/sims/lens_source.py Outdated Show resolved Hide resolved
@ConnorStoneAstro ConnorStoneAstro merged commit c29fd42 into dev Jul 5, 2024
13 checks passed
@ConnorStoneAstro ConnorStoneAstro deleted the quasarmicrolens branch July 5, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants