Add pageAction, specifically for Android: see #30

Android does not have browserAction, so we need pageAction. However I
could not figure out a way to fully disable pageAction on desktop
firefox. If it only shows up in the manifest, it still appears as greyed
out in the page action list, and the manifest does not seem to be
adjustable on a per-platform basis.

Hence, we enable it in all platforms. Users may hide or display it.

Also add a title to the browser action popup.

TODO: The browser popup needs to be adapted in Android, as it opens in a
new tab. It either needs to figure out from which tab it was opened and
show that tab's history, or needs to show all the tabs histories
together (possibly with some hint/filtering as to in which tab this
cleaning happened).

addon/_locales/en_US/messages.json

@@ -3,6 +3,10 @@
 	"message": "Converts obfuscated/nested links to genuine clean links",
 	"description": ""
 },
+"popup_description": {
+	"message": "Open cleaned links history",
+	"description": ""
+},
 "browser_status": {
 	"message": "Status:\u0020",
 	"description": ""

addon/background.js

@@ -293,6 +293,8 @@ loadOptions().then(() =>
 			lastRightClick.reply(cleanLink(link, tab.url))
 		});
 
+	browser.tabs.query({}).then(tablist => tablist.forEach(tab => browser.pageAction.show(tab.id)));
+
 	if (!prefValues.enabled)
 	{
 		setIcon(icon_disabled);
@@ -313,9 +315,17 @@ loadOptions().then(() =>
 		});
 
 	// Auto update badge text for pages when loading is complete
-	browser.tabs.onUpdated.addListener((id, changeInfo, tab) => {
-		if (cleanedPerTab.getCount(tab.id))
-			browser.browserAction.setBadgeText({tabId: id, text: '' + cleanedPerTab.getCount(tab.id)});
+	browser.tabs.onUpdated.addListener((id, changeInfo, tab) =>
+	{
+		browser.pageAction.show(id);
+
+		var ncleaned = cleanedPerTab.getCount(tab.id);
+		if (!ncleaned)
+			return;
+
+		browser.pageAction.setTitle({tabId: id, title: _('popup_description') + ' (' + ncleaned + ')'});
+		else
+			browser.browserAction.setBadgeText({tabId: id, text: '' + ncleaned});
 	});
 
 	browser.tabs.onRemoved.addListener((id, removeInfo) => {

addon/manifest.json

@@ -48,6 +48,15 @@
 	{
 		"browser_style": false,
 		"default_icon": "icons/32.png",
+		"default_title": "__MSG_popup_description__",
+		"default_popup": "popup.html"
+	},
+
+	"page_action":
+	{
+		"browser_style": false,
+		"default_icon": "icons/32.png",
+		"default_title": "__MSG_popup_description__",
 		"default_popup": "popup.html"
 	},