Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cleaned links history popup available on ff for android #30

Closed
Cimbali opened this issue Aug 15, 2018 · 1 comment
Closed

Make cleaned links history popup available on ff for android #30

Cimbali opened this issue Aug 15, 2018 · 1 comment
Labels
android enhancement New feature or request

Comments

@Cimbali
Copy link
Owner

Cimbali commented Aug 15, 2018

Use pageAction instead of browserAction if we detect that we are on the mobile browser.

See https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Differences_between_desktop_and_Android#Effect_on_your_add-on_UI
@Cimbali Cimbali added the enhancement New feature or request label Aug 15, 2018
Cimbali added a commit that referenced this issue Aug 19, 2018
@Cimbali
Add pageAction, specifically for Android: see #30
98a4a83 
Android does not have browserAction, so we need pageAction. However I
could not figure out a way to fully disable pageAction on desktop
firefox. If it only shows up in the manifest, it still appears as greyed
out in the page action list, and the manifest does not seem to be
adjustable on a per-platform basis.

Hence, we enable it in all platforms. Users may hide or display it.

Also add a title to the browser action popup.

TODO: The browser popup needs to be adapted in Android, as it opens in a
new tab. It either needs to figure out from which tab it was opened and
show that tab's history, or needs to show all the tabs histories
together (possibly with some hint/filtering as to in which tab this
cleaning happened).
@Cimbali Cimbali mentioned this issue Aug 24, 2018
Open
4 tasks
@Cimbali Cimbali mentioned this issue Jan 5, 2019
Closed
@Cimbali Cimbali added the android label Jan 5, 2019
@Cimbali
Copy link
Owner Author

Cimbali commented Mar 30, 2020

Also fixed in v4.1 release.

@Cimbali Cimbali closed this as completed Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
android enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Cimbali