Skip to content
This repository has been archived by the owner on Nov 4, 2019. It is now read-only.

Add package_url and arguments fields #4

Merged
merged 1 commit into from
Jul 2, 2015

Conversation

chrisbaldauf
Copy link
Contributor

Add some fields that I hadn't thought of before, but I think will prove useful.

@maclennann

@@ -27,7 +27,7 @@ Object.keys(db).forEach(function(modelName) {
}
});

sequelize.sync();
sequelize.sync({force: true});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this will drop and recreate all tables for an existing deployment. Yes, I plan to change this to a Sequelize data migration rather than just forcing the model sync on each startup.

@maclennann
Copy link
Contributor

Too bad there's no good way to marry model sync and migrations :person_frowning:.

Though the umzug migration library the sequelize folks provide seems to give a similar interface program-wise (so it's not like having to figure out how to shoehorn in a shell execution of the sequelize cli.

It'd be nice if it could provide best-guess migrations a-la EF code-first migrations, but I suppose one can't have everything.

edit:

Oh, but also :shipit: with the note that we should swap out force-sync with migrations (or at least just remove force-sync) soonish before we accidentally lose actual data.

chrisbaldauf added a commit that referenced this pull request Jul 2, 2015
Add package_url and arguments fields
@chrisbaldauf chrisbaldauf merged commit d14f91b into master Jul 2, 2015
@chrisbaldauf chrisbaldauf deleted the add_deployment_fields branch August 13, 2015 16:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants