Update Closure Compiler to v20160822 #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to make polyfills work, as discussed in CindyJS#444 (comment)
As closure compiler has recently started to enable polyfilling by default, we now may have references to synthetic polyfill sources as part of our source maps. We can't open these for inlining into the source map, so we have to recognize them and avoid relativizing their path.
|
This supersedes #444. |
|
@gagern Thanks for fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue identified in #444 (comment) and therefore works with active
--rewrite_polyfillsflag, at least in case of the julia set example. I haven't performed any other tests, though, so I think this should be tested some more before merging. At least to make sure that the examples that Stefan checked for #444 still work even with polyfills in place.