Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow file selector to be disabled #36

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

trducng
Copy link
Contributor

@trducng trducng commented Apr 16, 2024

image

No files will be considered during chat.

image

All files will be considered during chat.

image

Only selected files will be considered during chat. If no files are selected, no files will be considered.

Copy link
Contributor

@lone17 lone17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank @trducng. Just had some small comments.

Also please update the docs and screenshots:

libs/ktem/ktem/index/file/pipelines.py Outdated Show resolved Hide resolved
@trducng
Copy link
Contributor Author

trducng commented Apr 16, 2024

Very nice, thank @trducng. Just had some small comments.

Also please update the docs and screenshots:

Should update the ktem/assets/md/usage.md file as well @lone17

@lone17
Copy link
Contributor

lone17 commented Apr 16, 2024

Very nice, thank @trducng. Just had some small comments.
Also please update the docs and screenshots:

Should update the ktem/assets/md/usage.md file as well @lone17

oh yes, would be nice if you could copy-paste the docs/usage.md file to that one. That one is currently used for hf hub deployment only so it's not that important.

@trducng
Copy link
Contributor Author

trducng commented Apr 16, 2024

@lone17 I have updated, please check.

@lone17 lone17 self-requested a review April 16, 2024 11:35
Copy link
Contributor

@lone17 lone17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

One question though, should we auto select any newly added file ? If yes then let's address it in another PR, else please close #26.

@trducng
Copy link
Contributor Author

trducng commented Apr 16, 2024

LGTM.

One question though, should we auto select any newly added file ? If yes then let's address it in another PR, else please close #26.

I think we should keep the file selection explicit, since our app isn't a question answering demo, but a long-running app.

@trducng trducng merged commit 1b2082a into main Apr 16, 2024
6 checks passed
@lone17 lone17 deleted the feat/allow-file-selector-to-be-disabled branch April 16, 2024 11:44
phv2312 pushed a commit to phv2312/kotaemon that referenced this pull request Sep 11, 2024
* Allow file selector to be disabled

* Update docs and variable names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No file selected shouldn't mean all files are selected. Also, newly added file should be auto selected.
2 participants