Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build_and_push_image job and README #2

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Update build_and_push_image job and README #2

merged 1 commit into from
Dec 20, 2018

Conversation

rauny-brandao
Copy link
Contributor

Hey @iynere and @eddiewebb... me again 😅

I've updated the job build_and_push_image, so now it's possible to use the parameters:

  • dockerfile
  • path

Example:

...
workflows:
  build_and_push_image:
    jobs:
      - aws-ecr/build_and_push_image:
          context: myContext
          region: us-east-1
          account-url: 999999999999.dkr-ecr.us-west-2.amazonaws.com
          repo: myrepo
          tag: latest
          dockerfile: Dockerfile
          path: .

What do you guys think about this change?

Thanks!

@iynere
Copy link
Contributor

iynere commented Dec 10, 2018

ahh, i see—it was available in the command but not the job—thank you !! @rauny-brandao

@rauny-brandao
Copy link
Contributor Author

Hey @iynere,

Do you know when this pull request will be merged?

Thanks!

@iynere
Copy link
Contributor

iynere commented Dec 20, 2018

ahh thank you for the ping @rauny-brandao can get to this today

@iynere iynere merged commit 7cfc4d3 into CircleCI-Public:master Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants