Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to generate a default token on runner resource class creation [RT-6] #630

Merged

Conversation

christian-stephen
Copy link
Contributor

@christian-stephen christian-stephen commented Oct 4, 2021

Adds an option to the circleci runner resource-class create command to generate a resource-class token with the nickname default. This will help simplify the runner installation process.

@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #630 (d8243de) into master (ce8624c) will increase coverage by 0.36%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #630      +/-   ##
==========================================
+ Coverage   27.06%   27.43%   +0.36%     
==========================================
  Files          40       40              
  Lines        4481     4490       +9     
==========================================
+ Hits         1213     1232      +19     
+ Misses       3119     3108      -11     
- Partials      149      150       +1     
Impacted Files Coverage Δ
cmd/runner/instance.go 26.00% <0.00%> (ø)
cmd/runner/runner.go 75.00% <ø> (ø)
cmd/runner/token.go 55.00% <0.00%> (ø)
cmd/runner/resource_class.go 69.49% <80.00%> (+25.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce8624c...d8243de. Read the comment docs.

@christian-stephen christian-stephen force-pushed the RT-6/gen-token-on-rc-create branch 4 times, most recently from 071270d to 9292e1b Compare October 5, 2021 11:58
@christian-stephen christian-stephen marked this pull request as ready for review October 5, 2021 12:01
@pete-woods
Copy link
Contributor

If people have scripted this command, it's going to be a breaking change.

It might make more sense to make it non-default, and have our install instructions include a --generate-token flag.

@christian-stephen
Copy link
Contributor Author

If people have scripted this command, it's going to be a breaking change.

It might make more sense to make it non-default, and have our install instructions include a --generate-token flag.

Very valid point that also crossed my mind. I'll make the change and discuss with the team.

@christian-stephen christian-stephen changed the title Generate a default token on runner resource class creation [RT-6] Add option to generate a default token on runner resource class creation [RT-6] Oct 5, 2021
@christian-stephen christian-stephen force-pushed the RT-6/gen-token-on-rc-create branch 3 times, most recently from 955321b to b877efb Compare October 5, 2021 19:53
@lewang lewang merged commit a170bd3 into CircleCI-Public:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants