[semver:minor] Support GOOGLE_COMPUTE_REGION environment variable #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have made several PRs to CircleCI-Public organization and none of them have received any feedback. @iynere @FelicianoTech Please take a look at this PR. |
gmemstr
changed the title
wyardley
added a commit
to wyardley/gcp-cli-orb
that referenced
this pull request
Oct 30, 2021
Fixes CircleCI-Public#38 The changes in CircleCI-Public#23 make the initialize command fail if one of GOOGLE_COMPUTE_ZONE or GOOGLE_COMPUTE_REGION is not set. While having one of these set implicitly may be useful for some people, it is not required for all commands, and can also usually be specified via --zone, --region, or --location.
wyardley
added a commit
to wyardley/gcp-cli-orb
that referenced
this pull request
Oct 30, 2021
Fixes CircleCI-Public#38 The changes in CircleCI-Public#23 make the initialize command fail if one of GOOGLE_COMPUTE_ZONE or GOOGLE_COMPUTE_REGION is not set. While having one of these set implicitly may be useful for some people, it is not required for all commands, and can also usually be specified via --zone, --region, or --location. Also, clarify docs: - Clarify when it's the env var name vs. the value to use - Clarify wording so it's clear that these are the _default_ values for the CLI to use
wyardley
added a commit
to wyardley/gcp-cli-orb
that referenced
this pull request
Oct 30, 2021
Fixes CircleCI-Public#38 The changes in CircleCI-Public#23 make the initialize command fail if one of GOOGLE_COMPUTE_ZONE or GOOGLE_COMPUTE_REGION is not set. While having one of these set implicitly may be useful for some people, it is not required for all commands, and can also usually be specified via --zone, --region, or --location. Also, clarify docs: - Clarify when it's the env var name vs. the value to use - Clarify wording so it's clear that these are the _default_ values for the CLI to use
3 tasks
wyardley
added a commit
to wyardley/gcp-cli-orb
that referenced
this pull request
Oct 30, 2021
Fixes CircleCI-Public#38 The changes in CircleCI-Public#23 make the initialize command fail if one of GOOGLE_COMPUTE_ZONE or GOOGLE_COMPUTE_REGION is not set. While having one of these set implicitly may be useful for some people, it is not required for all commands, and can also usually be specified via --zone, --region, or --location. This will also enable _both_ to be set if the env vars exist. Also, clarify docs: - Clarify when it's the env var name vs. the value to use - Clarify wording so it's clear that these are the _default_ values for the CLI to use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Motivation, issues
Fixes Issue: CircleCI-Public/gcp-gke-orb#9
Description
Support GOOGLE_COMPUTE_REGION for gcloud CLI