Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only parse content if the response code is not 204 #83

Merged
merged 2 commits into from
Nov 23, 2018
Merged

Only parse content if the response code is not 204 #83

merged 2 commits into from
Nov 23, 2018

Conversation

SerethiX
Copy link
Contributor

Fixes #82

Proposed Changes

  • Check if the response code is 204 and skip JsonFormatter as we should not expect to see any data

@TobiasHauck
Copy link
Member

Thank you for the fix!

@TobiasHauck TobiasHauck merged commit c408340 into CircleOfNice:master Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiasHauck TobiasHauck Awaiting requested review from TobiasHauck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SerethiX @TobiasHauck