Skip to content

Commit

Permalink
feat: Add RBS to CI (#3833)
Browse files Browse the repository at this point in the history
* fix(rbs/ci): fix meta-tags issue

* feat(rbs/ci): remove manual import from steepfile

* feat(rbs/ci): add meta-tags rbs file to sig folder to check with steep

* feat(rbs/ci): add steep to CI

* feat(rbs/ci): ci fix
  • Loading branch information
tanmoysrt committed Jun 26, 2023
1 parent 81222fd commit 1cc7ab7
Show file tree
Hide file tree
Showing 14 changed files with 331 additions and 35 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/rubyonrails.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ jobs:
run: |
git fetch --no-tags
reviewdog -reporter=github-pr-review -runners=undercover --fail-on-error
- name: Static type checking
run: |
bundle exec rbs collection install
bundle exec steep check
lint:
runs-on: ubuntu-latest
steps:
Expand Down
94 changes: 59 additions & 35 deletions rbs_collection.lock.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
sources:
- type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
path: ".gem_rbs_collection"
Expand All @@ -12,95 +12,111 @@ gems:
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: actionpack
version: '6.0'
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: actionview
version: '6.0'
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: activejob
version: '6.0'
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: activemodel
version: '7.0'
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: activerecord
version: '7.0'
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: activestorage
version: '6.1'
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: activesupport
version: '7.0'
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: ast
version: '2.4'
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: aws-sdk-core
version: '3'
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: aws-sdk-kms
version: '1'
source:
type: git
name: ruby/gem_rbs_collection
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: aws-sdk-s3
version: '1'
source:
type: git
name: ruby/gem_rbs_collection
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: aws-sdk-sqs
version: '1'
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: bcrypt
version: '3.1'
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: cgi
Expand All @@ -112,7 +128,7 @@ gems:
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: date
Expand All @@ -124,15 +140,15 @@ gems:
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: faraday
version: '2.5'
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: forwardable
Expand All @@ -144,23 +160,23 @@ gems:
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: hashie
version: '5.0'
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: i18n
version: '1.10'
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: io-console
Expand All @@ -176,23 +192,23 @@ gems:
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: kaminari-core
version: '1.2'
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: listen
version: '3.2'
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: logger
Expand All @@ -204,13 +220,9 @@ gems:
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: meta-tags
version: 2.16.0
source:
type: rubygems
- name: minitest
version: '0'
source:
Expand All @@ -228,7 +240,7 @@ gems:
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: openssl
Expand All @@ -240,39 +252,43 @@ gems:
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: pathname
version: '0'
source:
type: stdlib
- name: rack
version: '2.2'
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: rails-dom-testing
version: '2.0'
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: railties
version: '6.0'
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: rainbow
version: '3.0'
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: rbs_rails
Expand All @@ -284,15 +300,23 @@ gems:
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: sidekiq
version: '6.2'
source:
type: git
name: ruby/gem_rbs_collection
revision: 80c41dad0190d5968841b8e892523e5031fa3eb1
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: simplecov
version: '0.22'
source:
type: git
name: ruby/gem_rbs_collection
revision: 87fba082504c606c03edf724cdf2e119bcd46c8c
remote: https://github.com/ruby/gem_rbs_collection.git
repo_dir: gems
- name: singleton
Expand Down
2 changes: 2 additions & 0 deletions rbs_collection.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,5 @@ gems:
ignore: true
- name: steep
ignore: true
- name: meta-tags
ignore: true
15 changes: 15 additions & 0 deletions sig/vendor/meta_tags/_rails.rbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
interface _ActionControllerBase
def render: (*untyped args) { () -> untyped } -> untyped
end

interface _ActionViewBase
def tag: (String name, ?Hash[String | Symbol, untyped] options, ?bool open) -> void

def content_tag: (String name, String content, ?Hash[String | Symbol, untyped] options, ?bool open) -> void

def safe_join: (Array[String], String) -> String

def truncate: (String text, ?Hash[Symbol, untyped] options) -> String

def strip_tags: (String html) -> String
end
16 changes: 16 additions & 0 deletions sig/vendor/meta_tags/meta_tags.rbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
module MetaTags
def self.config: () -> Configuration
def self.configure: () { (Configuration) -> void } -> void

interface _Stringish
def to_str: () -> String
end

interface _Timish
def iso8601: () -> String
end

interface _MetaTagish
def to_meta_tags: () -> Hash[String | Symbol, untyped]
end
end
19 changes: 19 additions & 0 deletions sig/vendor/meta_tags/meta_tags/configuration.rbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
module MetaTags
class Configuration
attr_accessor title_limit: Integer?
attr_accessor truncate_site_title_first: bool
attr_accessor description_limit: Integer
attr_accessor keywords_limit: Integer
attr_accessor keywords_separator: String
attr_accessor keywords_lowercase: bool
attr_accessor open_meta_tags: bool
attr_accessor minify_output: bool
attr_reader property_tags: Array[String | Symbol]
attr_accessor skip_canonical_links_on_noindex: bool

def initialize: () -> void
def default_property_tags: () -> Array[String | Symbol]
def open_meta_tags?: () -> bool
def reset_defaults!: () -> void
end
end
5 changes: 5 additions & 0 deletions sig/vendor/meta_tags/meta_tags/content_tag.rbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
module MetaTags
class ContentTag < Tag
def render: (_ActionViewBase view) -> untyped
end
end

0 comments on commit 1cc7ab7

Please sign in to comment.