feat: Add RBS to CI #3833
Merged
feat: Add RBS to CI #3833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
11 tasks
|
Code Climate has analyzed commit 268e583 and detected 0 issues on this pull request. View more on Code Climate. |
|
This PR is ready ! |
tachyons
approved these changes
Jun 26, 2023
tanmoysrt
added a commit
to tanmoysrt/CircuitVerse
that referenced
this pull request
Jul 18, 2023
* fix(rbs/ci): fix meta-tags issue * feat(rbs/ci): remove manual import from steepfile * feat(rbs/ci): add meta-tags rbs file to sig folder to check with steep * feat(rbs/ci): add steep to CI * feat(rbs/ci): ci fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3792
Describe the changes you have made in this PR -
meta-tagsto ignore, so that the rbs of meta-tags don't raise any issuesig/vendor, added modifiedrbsofmeta-tagsgem to process it withsteep checksteep checkin CIFor resolving the
RBS::DuplicatedMethodDefinitionErrorissue for conflicting rbs definition , the maintainer of steep suggests to ignoremeta-tagsfrom rbs check and store modifiedrbsin sig folder for steep check.Dicussion Thread - ruby/rbs:1359
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.