Testbench: New UI and Refactor #2366

gr455 · 2021-07-30T06:32:18Z

Implemented new UI
Detailed Results UI
Creator Integration with simulator
Serving simulator view through rails and webpack

- Implemented new UI - Prototype Detailed Results UI

- Test is loaded when circuit is loaded - UI Fixes - Escaping user input before appending to DOM

- Testbench UI on simulator changes with theme

- Update TB on new circuit - Fix Testbench JSON dialog font color - Remove TB creator extra whitespace in identifiers - Hide TB UI from layoutMode

commit-lint · 2021-07-30T06:32:21Z

Testbench

Refactor data and fix many bugs (6fbc41c)

Contributors

gr455

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

@Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
@Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
@Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
@Commit-Lint merge disable will desactivate merge dependabot PR
@Commit-Lint review will approve dependabot PR
@Commit-Lint stop review will stop approve dependabot PR

accesslint

There are accessibility issues in these changes.

accesslint · 2021-07-30T06:33:35Z

app/views/simulator/edit.html.erb

+      <div style="overflow: auto; margin-bottom: 10px;">
+        <div class="tb-manual-test-buttons tb-group-buttons">
+          <span style="line-height: 24px; margin-right: 5px;"><b>Group: </b></span>
+          <button class="custom-btn--primary panel-button tb-case-button-left tb-case-button" id="prev-group-btn"><i class="tb-case-arrow tb-case-arrow-left"></i></button>


Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

accesslint · 2021-07-30T06:33:36Z

app/views/simulator/edit.html.erb

+          <span style="line-height: 24px; margin-right: 5px;"><b>Group: </b></span>
+          <button class="custom-btn--primary panel-button tb-case-button-left tb-case-button" id="prev-group-btn"><i class="tb-case-arrow tb-case-arrow-left"></i></button>
+          <span class="tb-test-label group-label"></span>
+          <button class="custom-btn--primary panel-button tb-case-button-right tb-case-button" id="next-group-btn"><i class="tb-case-arrow tb-case-arrow-right"></i></button>


Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

accesslint · 2021-07-30T06:33:36Z

app/views/simulator/edit.html.erb

+        </div>
+        <div class="tb-manual-test-buttons tb-case-buttons">
+          <span style="line-height: 24px; margin-right: 5px;"><b>Case: </b></span>
+          <button class="custom-btn--primary panel-button tb-case-button-left tb-case-button" id="prev-case-btn"><i class="tb-case-arrow tb-case-arrow-left"></i></button>


Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

accesslint · 2021-07-30T06:33:36Z

app/views/simulator/edit.html.erb

+          <span style="line-height: 24px; margin-right: 5px;"><b>Case: </b></span>
+          <button class="custom-btn--primary panel-button tb-case-button-left tb-case-button" id="prev-case-btn"><i class="tb-case-arrow tb-case-arrow-left"></i></button>
+          <span class="tb-test-label case-label"></span>
+          <button class="custom-btn--primary panel-button tb-case-button-right tb-case-button" id="next-case-btn"><i class="tb-case-arrow tb-case-arrow-right"></i></button>


Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

coveralls · 2021-07-30T06:35:29Z

Coverage decreased (-0.1%) to 84.602% when pulling 23d2880 on gr455:tb-ui-2 into 373bdb9 on CircuitVerse:testbench.

- refactor: Use TestbenchData class to store testbench related data - feat: UI Buttons run validation everytime - fix: Copy pasting removes testbench data from scope - fix: Showing validation error causes circuit to block

satu0king · 2021-08-12T13:29:13Z

simulator/src/events.js

+            oldTestbenchData.currentCase
+        );
+    }
+


Note this hack

satu0king · 2021-08-12T13:30:46Z

simulator/src/testbench.js

+     * @param {number} caseIndex -  Case index to set
+     */
+    setCase(groupIndex, caseIndex) {
+        const newCase = new TestbenchData(this.testData, groupIndex, caseIndex);


Creating a new object here seems odd?

That object is used to do temporary operations on to check if the case and group are valid, if they are valid then those changes are made to the real object

This commit adds popup to access creator from simulator. Also removes outdated code Signed-off-by: Ruturaj Mohite <mohite.ruturaj15@gmail.com>

hound · 2021-08-14T06:23:35Z

app/views/simulator/edit.html.erb

  style="display: none;"
-  title="TestBench"
+  title="Create Test"


Extra space detected where there should be no space.

accesslint

There are accessibility issues in these changes.

accesslint · 2021-08-14T06:23:46Z

app/views/simulator/edit.html.erb

+      <div style="overflow: auto; margin-bottom: 10px;">
+        <div class="tb-manual-test-buttons tb-group-buttons">
+          <span style="line-height: 24px; margin-right: 5px;"><b>Group: </b></span>
+          <button class="custom-btn--basic panel-button tb-case-button-left tb-case-button" id="prev-group-btn"><i class="tb-case-arrow tb-case-arrow-left"></i></button>


Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

accesslint · 2021-08-14T06:23:46Z

app/views/simulator/edit.html.erb

+          <span style="line-height: 24px; margin-right: 5px;"><b>Group: </b></span>
+          <button class="custom-btn--basic panel-button tb-case-button-left tb-case-button" id="prev-group-btn"><i class="tb-case-arrow tb-case-arrow-left"></i></button>
+          <span class="tb-test-label group-label"></span>
+          <button class="custom-btn--basic panel-button tb-case-button-right tb-case-button" id="next-group-btn"><i class="tb-case-arrow tb-case-arrow-right"></i></button>


Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

accesslint · 2021-08-14T06:23:46Z

app/views/simulator/edit.html.erb

+        </div>
+        <div class="tb-manual-test-buttons tb-case-buttons">
+          <span style="line-height: 24px; margin-right: 5px;"><b>Case: </b></span>
+          <button class="custom-btn--basic panel-button tb-case-button-left tb-case-button" id="prev-case-btn"><i class="tb-case-arrow tb-case-arrow-left"></i></button>


Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

accesslint · 2021-08-14T06:23:46Z

app/views/simulator/edit.html.erb

+          <span style="line-height: 24px; margin-right: 5px;"><b>Case: </b></span>
+          <button class="custom-btn--basic panel-button tb-case-button-left tb-case-button" id="prev-case-btn"><i class="tb-case-arrow tb-case-arrow-left"></i></button>
+          <span class="tb-test-label case-label"></span>
+          <button class="custom-btn--basic panel-button tb-case-button-right tb-case-button" id="next-case-btn"><i class="tb-case-arrow tb-case-arrow-right"></i></button>


Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

- Validation UI shows list of validation errors - Auto fix to fix bitwidth errors Signed-off-by: Ruturaj Mohite <mohite.ruturaj15@gmail.com>

hound · 2021-08-15T05:50:28Z

app/views/simulator/edit.html.erb

  style="display: none;"
-  title="TestBench"
+  title="Testbench Validation"


Extra space detected where there should be no space.

Signed-off-by: Ruturaj Mohite <mohite.ruturaj15@gmail.com>

hound · 2021-08-15T10:40:10Z

app/views/testbench/creator.html.erb

+            </div>
+    </div>
+
+</body>


Missing a trailing newline at the end of the file.

* Testbench/Engine: Add Engine support for combinational tests - UI for creating tests (for now served as a static html file) - Implemented testbench engine for Combinational Tests - Validation for I/O, Clock and Reset pins - Runs tests as fast as possible without rendering(to increase speed) on Simulator - Currently uses Labels for identification of I/O. To be deprecated in favour of identifiers * Testbench engine stops the clock and runs tests by controlling the clock itself. This is required so that tests are not throttled by clock time. * Testbench engine returns test results with observed output next to expected output * Testbench engine returns with failure message on validation failure * Testbench/Engine: Support Sequential Tests for RUNALL - Engine now supports sequential tests - Clock ticks full cycle when inputs are propagated - Reset is triggered at the end of each Set * Testbench/Engine: Add Manual Mode and UI Added Manual Mode that lets user step through tests and run a single test at a time. Manual Mode can be accessed in Tools > Use TestBench > Run Manually on the simulator. Change log: - Added Manual Mode UI - Added styles for Manual Mode UI - Added Engine functions for Manual Mode - Improved ESLint compliance * Testbench: Fix UI and Creator Fixes - Fixed Manual Mode allignment - Fixed Creator Labels getting extra whitespace * TestBench/Creator: Creator UI Additions - Added interface to delete inputs/outputs and cases - Added showError to testbench on simulator to display validation errors * Redo undone i18n * Validate proper JSON input * Testbench: New UI and Refactor (#2366) * Testbench/UI: New UI for Testbench on Simulator - Implemented new UI - Prototype Detailed Results UI * Testbench/Data: Persist test in Circuit's backupData - Test is loaded when circuit is loaded - UI Fixes - Escaping user input before appending to DOM * Testbench/Creator: Add case reordering for Test Creator * Testbench/UI: Themes Compatibility - Testbench UI on simulator changes with theme * Testbench/UI: Fix Multiple UI Issues - Update TB on new circuit - Fix Testbench JSON dialog font color - Remove TB creator extra whitespace in identifiers - Hide TB UI from layoutMode * Testbench: Refactor data and fix many bugs - refactor: Use TestbenchData class to store testbench related data - feat: UI Buttons run validation every time - fix: Copy pasting removes testbench data from scope - fix: Showing validation error causes circuit to block * Testbench/Creator: Add popUp for creator from simulator This commit adds popup to access creator from simulator. Also removes outdated code Signed-off-by: Ruturaj Mohite <mohite.ruturaj15@gmail.com> * Testbench/UI: Add Validation UI - Validation UI shows list of validation errors - Auto fix to fix bitwidth errors Signed-off-by: Ruturaj Mohite <mohite.ruturaj15@gmail.com> * Testbench/Creator: Improve result UI Signed-off-by: Ruturaj Mohite <mohite.ruturaj15@gmail.com> * Testbench/Creator: Server Creator through rails and webpack Signed-off-by: Ruturaj Mohite <mohite.ruturaj15@gmail.com> * Fix: Creator table helper fix * Feat: Import and export tests using CSV files Signed-off-by: Ruturaj Mohite <mohite.ruturaj15@gmail.com> Co-authored-by: Aboobacker MK <aboobackervyd@gmail.com>

gr455 added 5 commits July 15, 2021 22:49

Testbench/UI: New UI for Testbench on Simulator

a6937ba

- Implemented new UI - Prototype Detailed Results UI

Testbench/Data: Persist test in Circuit's backupData

240683a

- Test is loaded when circuit is loaded - UI Fixes - Escaping user input before appending to DOM

Testbench/Creator: Add case reordering for Test Creator

600ea5a

Testbench/UI: Themes Compatibility

edc8971

- Testbench UI on simulator changes with theme

Testbench/UI: Fix Multiple UI Issues

3f6224b

- Update TB on new circuit - Fix Testbench JSON dialog font color - Remove TB creator extra whitespace in identifiers - Hide TB UI from layoutMode

gr455 mentioned this pull request Jul 30, 2021

Testbench/UI: New UI for Testbench on Simulator and Creator #2330

Closed

accesslint bot suggested changes Jul 30, 2021

View reviewed changes

Testbench: Refactor data and fix many bugs

6fbc41c

- refactor: Use TestbenchData class to store testbench related data - feat: UI Buttons run validation everytime - fix: Copy pasting removes testbench data from scope - fix: Showing validation error causes circuit to block

gr455 changed the title ~~Testbench/UI: New UI for Testbench on Simulator and Creator~~ Testbench: New UI and Refactor Jul 31, 2021

gr455 requested a review from satu0king July 31, 2021 12:10

satu0king reviewed Aug 12, 2021

View reviewed changes

simulator/src/events.js

oldTestbenchData.currentCase

);

}

Copy link

Member

satu0king Aug 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this hack

gr455 reacted with thumbs up emoji

satu0king reviewed Aug 12, 2021

View reviewed changes

Testbench/Creator: Add popUp for creator from simulator

6377789

This commit adds popup to access creator from simulator. Also removes outdated code Signed-off-by: Ruturaj Mohite <mohite.ruturaj15@gmail.com>

hound bot reviewed Aug 14, 2021

View reviewed changes

accesslint bot suggested changes Aug 14, 2021

View reviewed changes

Testbench/UI: Add Validation UI

44ec828

- Validation UI shows list of validation errors - Auto fix to fix bitwidth errors Signed-off-by: Ruturaj Mohite <mohite.ruturaj15@gmail.com>

hound bot reviewed Aug 15, 2021

View reviewed changes

gr455 added 2 commits August 15, 2021 15:07

Testbench/Creator: Improve result UI

55ef050

Signed-off-by: Ruturaj Mohite <mohite.ruturaj15@gmail.com>

Testbench/Creator: Server Creator through rails and webpack

28aac13

Signed-off-by: Ruturaj Mohite <mohite.ruturaj15@gmail.com>

hound bot reviewed Aug 15, 2021

View reviewed changes

app/views/testbench/creator.html.erb

</div>

</div>

</body>

Copy link

hound bot Aug 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a trailing newline at the end of the file.

gr455 added the 🌟 feature label Aug 15, 2021

Fix: Creator table helper fix

23d2880

satu0king merged commit f055222 into CircuitVerse:testbench Aug 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Testbench: New UI and Refactor #2366

Testbench: New UI and Refactor #2366

gr455 commented Jul 30, 2021 •

edited

Loading

commit-lint bot commented Jul 30, 2021 •

edited

Loading

accesslint bot left a comment

accesslint bot Jul 30, 2021

accesslint bot Jul 30, 2021

accesslint bot Jul 30, 2021

accesslint bot Jul 30, 2021

coveralls commented Jul 30, 2021 •

edited

Loading

satu0king Aug 12, 2021

satu0king Aug 12, 2021

gr455 Aug 12, 2021

hound bot Aug 14, 2021

accesslint bot left a comment

accesslint bot Aug 14, 2021

accesslint bot Aug 14, 2021

accesslint bot Aug 14, 2021

accesslint bot Aug 14, 2021

hound bot Aug 15, 2021

hound bot Aug 15, 2021

+                          </div>
+                  </div>
+              </body>

Testbench: New UI and Refactor #2366

Testbench: New UI and Refactor #2366

Conversation

gr455 commented Jul 30, 2021 • edited Loading

commit-lint bot commented Jul 30, 2021 • edited Loading

Testbench

Contributors

accesslint bot left a comment

Choose a reason for hiding this comment

accesslint bot Jul 30, 2021

Choose a reason for hiding this comment

accesslint bot Jul 30, 2021

Choose a reason for hiding this comment

accesslint bot Jul 30, 2021

Choose a reason for hiding this comment

accesslint bot Jul 30, 2021

Choose a reason for hiding this comment

coveralls commented Jul 30, 2021 • edited Loading

satu0king Aug 12, 2021

Choose a reason for hiding this comment

satu0king Aug 12, 2021

Choose a reason for hiding this comment

gr455 Aug 12, 2021

Choose a reason for hiding this comment

hound bot Aug 14, 2021

Choose a reason for hiding this comment

accesslint bot left a comment

Choose a reason for hiding this comment

accesslint bot Aug 14, 2021

Choose a reason for hiding this comment

accesslint bot Aug 14, 2021

Choose a reason for hiding this comment

accesslint bot Aug 14, 2021

Choose a reason for hiding this comment

accesslint bot Aug 14, 2021

Choose a reason for hiding this comment

hound bot Aug 15, 2021

Choose a reason for hiding this comment

hound bot Aug 15, 2021

Choose a reason for hiding this comment

gr455 commented Jul 30, 2021 •

edited

Loading

commit-lint bot commented Jul 30, 2021 •

edited

Loading

coveralls commented Jul 30, 2021 •

edited

Loading