feat: adding collaborator via invitation link #2675

vedant-jain03 · 2021-12-06T12:41:47Z

Fixes #2307

Describe the changes you have made in this PR -

Migration file to add new column collaboration_token, index, and token_expires_at in Project table
Functionality to add members to the group via link
Different conditions like if the collaborator is already present, URL not valid, token expired.
Expiry date of token is 12 days.

Screenshots of the changes (If any) -

CircuitVerse.-.Untitled.-.Google.Chrome.2021-12-06.18-03-31.mp4

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

hound · 2021-12-06T12:41:51Z

app/views/projects/_add_collaborator_modal.html.erb

    </div>
  </div>
+


Extra whitespace detected at end of line.

accesslint

There are accessibility issues in these changes.

accesslint · 2021-12-06T12:41:58Z

app/views/projects/_add_collaborator_modal.html.erb

+          <span><%= t("projects.invite_link_btn") %></span>
+        <% end %>
+        <div class="collapse" id="multiCollapseExample2">
+          <textarea id="embedInviteLink" class="collaborator-invite-link-text" rows="4" cols="35"></textarea>


Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

@vedant-jain03 Why this is closed ?

@tachyons I thought it is just readonly textarea as we are only rendering the link for the invitation, there should not be any modification from the user end to the invitation link.
WDYT should I add a label for it sir @tachyons ? I will add readonly="readonly" attribute for the element.

vedant-jain03 · 2021-12-06T12:43:30Z

@tachyons @pavanjoshi914 @Shivansh2407 @nitin10s Kindly Review.

app/controllers/projects_controller.rb

app/models/project.rb

coveralls · 2021-12-06T12:46:06Z

Coverage decreased (-0.9%) to 80.792% when pulling b06392e on vedant-jain03:issue2307 into d6d4f71 on CircuitVerse:master.

tachyons · 2021-12-06T13:01:22Z

You can follow the rest conventions by tweaking the URL.

Token generation should be

POST /projects/:id/collaboration

vedant-jain03 · 2021-12-12T04:08:27Z

@tachyons @pavanjoshi914 Kindly review

I have added a new inherited class collaboration controller and added create method under which token generation will execute

app/controllers/projects/collaboration_token_controller.rb

app/controllers/projects_controller.rb

app/models/project.rb

app/controllers/projects_controller.rb

vedant-jain03 · 2021-12-12T05:19:12Z

@tachyons @pavanjoshi914 @satu0king @gr455 I have a suggestion, what if we can also change the design of showing collaborators just like showing group members. As it is space-optimized.
@nitin10s

nitin10s · 2021-12-21T20:06:50Z

Let's leave it as it is, for now, we'll revisit certain sections like these and design them appropriately.

vedant-jain03 · 2021-12-22T02:52:37Z

Let's leave it as it is, for now, we'll revisit certain sections like these and design them appropriately.

Sure

vedant-jain03 · 2022-01-06T06:13:54Z

@tachyons @gr455 Any feedback sir?

app/controllers/projects_controller.rb

gr455

This doesn't work when the Project access type is Private, although I can add collaborators in Private projects by email

vedant-jain03 · 2022-01-06T07:07:45Z

This doesn't work when the Project access type is Private, although I can add collaborators in Private projects by email

I think this is working, have a look:

bandicam.2022-01-06.13-09-34-943.mp4

app/controllers/projects_controller.rb

gr455 · 2022-01-07T06:35:36Z

This doesn't work when the Project access type is Private, although I can add collaborators in Private projects by email

I think this is working, have a look:

bandicam.2022-01-06.13-09-34-943.mp4

Oh, I had pasted the link in an unauthenticated session (incognito). Instead of directing me to login, it just showed me the unauthorized message

vedant-jain03 · 2022-01-07T06:40:32Z

This doesn't work when the Project access type is Private, although I can add collaborators in Private projects by email

I think this is working, have a look:
bandicam.2022-01-06.13-09-34-943.mp4

Oh, I had pasted the link in an unauthenticated session (incognito). Instead of directing me to login, it just showed me the unauthorized message

Oh 😅,so WDYT?

vedant-jain03 · 2022-01-20T08:39:35Z

@tachyons Kindly provide me feedback for this PR sir.

app/controllers/projects_controller.rb

app/views/projects/_add_collaborator_modal.html.erb

…nly to textarea

accesslint

There are accessibility issues in these changes.

accesslint · 2022-01-25T10:44:39Z

app/views/projects/_add_collaborator_modal.html.erb

@@ -1,6 +1,6 @@
 <script src="https://cdn.jsdelivr.net/bootstrap.tagsinput/0.8.0/bootstrap-tagsinput.min.js"></script>

-<div id="collaboratorModal" class="modal fade" role="dialog">
+<div id="collaboratorModal" class="modal fade" role="dialog" data-controller="projectCollaboration">


Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

accesslint · 2022-01-25T10:44:39Z

app/views/projects/_add_collaborator_modal.html.erb

+          <span><%= t("projects.invite_link_btn") %></span>
+        <% end %>
+        <div class="collapse" id="multiCollapseExample2">
+          <textarea readonly="readonly" id="embedInviteLink" class="collaborator-invite-link-text" rows="4" cols="35"><%= user_project_url %>/invite/<%= @project.collaboration_token %></textarea>


Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

app/controllers/projects/invitations_controller.rb

vedant-jain03 · 2022-01-25T11:01:35Z

@tachyons

I have added integration with the stimulus controller.
Move project_invite to project/invitation#create.
Added check if the collaborator is the author.
Added readonly property to textarea.

app/controllers/projects/invitations_controller.rb

app/javascript/controllers/projectCollaboration_controller.js

accesslint

There are accessibility issues in these changes.

app/views/projects/_add_collaborator_modal.html.erb

app/javascript/controllers/projectCollaboration_controller.js

codeclimate · 2022-01-25T17:45:54Z

Code Climate has analyzed commit b06392e and detected 11 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	3
Style	7
Bug Risk	1

View more on Code Climate.

vedant-jain03 · 2022-02-16T03:06:53Z

@gr455 Any views for this PR?

vedant-jain03 · 2022-02-26T15:38:44Z

@tachyons Any feedback for this, sir?

tachyons

codeclimate warnings are closed without addressing them

feat: adding collaborator via invitation link

bc79f09

hound bot reviewed Dec 6, 2021

View reviewed changes

app/views/projects/_add_collaborator_modal.html.erb

</div>

</div>

Copy link

hound bot Dec 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra whitespace detected at end of line.

accesslint bot reviewed Dec 6, 2021

View reviewed changes

fixes: typo

c6c76f5

codeclimate bot reviewed Dec 6, 2021

View reviewed changes

fixes: changes the request of collaboration_token from put to post

5fdb976

codeclimate bot reviewed Dec 12, 2021

View reviewed changes

fixes: codeclimate issue

5362248

codeclimate bot reviewed Dec 12, 2021

View reviewed changes

app/controllers/projects_controller.rb Outdated Show resolved Hide resolved

vedant-jain03 changed the title ~~feat: adding collaborator via invitation link~~ feat: added collaborator via invitation link Dec 12, 2021

vedant-jain03 changed the title ~~feat: added collaborator via invitation link~~ feat: adding collaborator via invitation link Dec 12, 2021

gr455 reviewed Jan 6, 2022

View reviewed changes

app/controllers/projects_controller.rb Outdated Show resolved Hide resolved

gr455 requested changes Jan 6, 2022

View reviewed changes

fix: authenticated user results

bb6cd8e

vedant-jain03 force-pushed the issue2307 branch from a7cfd55 to bb6cd8e Compare January 6, 2022 07:47

vedant-jain03 requested a review from gr455 January 6, 2022 07:48

codeclimate bot reviewed Jan 6, 2022

View reviewed changes

app/controllers/projects_controller.rb Outdated Show resolved Hide resolved

vedant-jain03 requested a review from tachyons January 20, 2022 08:40

tachyons reviewed Jan 24, 2022

View reviewed changes

app/controllers/projects_controller.rb Outdated Show resolved Hide resolved

tachyons reviewed Jan 24, 2022

View reviewed changes

app/views/projects/_add_collaborator_modal.html.erb Outdated Show resolved Hide resolved

tachyons reviewed Jan 24, 2022

View reviewed changes

app/views/projects/_add_collaborator_modal.html.erb Outdated Show resolved Hide resolved

fix: stimulus intergation, project/invitation controller, added reado…

0fcd47f

…nly to textarea

vedant-jain03 force-pushed the issue2307 branch from 5ff8f30 to 0fcd47f Compare January 25, 2022 10:44

accesslint bot reviewed Jan 25, 2022

View reviewed changes

codeclimate bot reviewed Jan 25, 2022

View reviewed changes

vedant-jain03 requested a review from tachyons January 25, 2022 10:47

fix: refactor create method

a8ef952

codeclimate bot reviewed Jan 25, 2022

View reviewed changes

fix: onclick event integration using stimulus

79586c4

vedant-jain03 force-pushed the issue2307 branch from 87c9f44 to 79586c4 Compare January 25, 2022 17:32

accesslint bot reviewed Jan 25, 2022

View reviewed changes

app/views/projects/_add_collaborator_modal.html.erb Show resolved Hide resolved

app/views/projects/_add_collaborator_modal.html.erb Show resolved Hide resolved

vedant-jain03 added 2 commits January 25, 2022 23:03

Update _add_collaborator_modal.html.erb

f7c33a5

Merge branch 'master' into issue2307

1bf3376

codeclimate bot reviewed Jan 25, 2022

View reviewed changes

Update projectCollaboration_controller.js

b06392e

tachyons requested changes Feb 3, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: adding collaborator via invitation link #2675

feat: adding collaborator via invitation link #2675

vedant-jain03 commented Dec 6, 2021

hound bot Dec 6, 2021

accesslint bot left a comment

accesslint bot Dec 6, 2021

tachyons Jan 24, 2022

vedant-jain03 Jan 25, 2022 •

edited

Loading

vedant-jain03 commented Dec 6, 2021 •

edited

Loading

coveralls commented Dec 6, 2021 •

edited

Loading

tachyons commented Dec 6, 2021

vedant-jain03 commented Dec 12, 2021 •

edited

Loading

vedant-jain03 commented Dec 12, 2021 •

edited

Loading

nitin10s commented Dec 21, 2021

vedant-jain03 commented Dec 22, 2021

vedant-jain03 commented Jan 6, 2022

gr455 left a comment

vedant-jain03 commented Jan 6, 2022 •

edited

Loading

gr455 commented Jan 7, 2022

vedant-jain03 commented Jan 7, 2022 •

edited

Loading

vedant-jain03 commented Jan 20, 2022 •

edited

Loading

accesslint bot left a comment

accesslint bot Jan 25, 2022

accesslint bot Jan 25, 2022

vedant-jain03 commented Jan 25, 2022

accesslint bot left a comment

codeclimate bot commented Jan 25, 2022

vedant-jain03 commented Feb 16, 2022

vedant-jain03 commented Feb 26, 2022

tachyons left a comment

feat: adding collaborator via invitation link #2675

Are you sure you want to change the base?

feat: adding collaborator via invitation link #2675

Conversation

vedant-jain03 commented Dec 6, 2021

Describe the changes you have made in this PR -

Screenshots of the changes (If any) -

hound bot Dec 6, 2021

Choose a reason for hiding this comment

accesslint bot left a comment

Choose a reason for hiding this comment

accesslint bot Dec 6, 2021

Choose a reason for hiding this comment

tachyons Jan 24, 2022

Choose a reason for hiding this comment

vedant-jain03 Jan 25, 2022 • edited Loading

Choose a reason for hiding this comment

vedant-jain03 commented Dec 6, 2021 • edited Loading

coveralls commented Dec 6, 2021 • edited Loading

tachyons commented Dec 6, 2021

vedant-jain03 commented Dec 12, 2021 • edited Loading

vedant-jain03 commented Dec 12, 2021 • edited Loading

nitin10s commented Dec 21, 2021

vedant-jain03 commented Dec 22, 2021

vedant-jain03 commented Jan 6, 2022

gr455 left a comment

Choose a reason for hiding this comment

vedant-jain03 commented Jan 6, 2022 • edited Loading

gr455 commented Jan 7, 2022

vedant-jain03 commented Jan 7, 2022 • edited Loading

vedant-jain03 commented Jan 20, 2022 • edited Loading

accesslint bot left a comment

Choose a reason for hiding this comment

accesslint bot Jan 25, 2022

Choose a reason for hiding this comment

accesslint bot Jan 25, 2022

Choose a reason for hiding this comment

vedant-jain03 commented Jan 25, 2022

accesslint bot left a comment

Choose a reason for hiding this comment

codeclimate bot commented Jan 25, 2022

vedant-jain03 commented Feb 16, 2022

vedant-jain03 commented Feb 26, 2022

tachyons left a comment

Choose a reason for hiding this comment

vedant-jain03 Jan 25, 2022 •

edited

Loading

vedant-jain03 commented Dec 6, 2021 •

edited

Loading

coveralls commented Dec 6, 2021 •

edited

Loading

vedant-jain03 commented Dec 12, 2021 •

edited

Loading

vedant-jain03 commented Dec 12, 2021 •

edited

Loading

vedant-jain03 commented Jan 6, 2022 •

edited

Loading

vedant-jain03 commented Jan 7, 2022 •

edited

Loading

vedant-jain03 commented Jan 20, 2022 •

edited

Loading