Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#505 add quiz fsm #520

Closed
wants to merge 12 commits into from
Closed

Feature/#505 add quiz fsm #520

wants to merge 12 commits into from

Conversation

ritik307
Copy link
Contributor

Added Pop Quiz in the docs/seq-design

Fixes #505

Changes done:

  • Pop Quiz in fsm.md

Screenshots

FSM

Preview Link(s):

✅️ By submitting this PR, I have verified the following

  • Checked to see if a similar PR has already been opened 🤔️
  • Reviewed the contributing guidelines 🔍️
  • Sample preview link added (add the link(s) for all the pages changed/updated from the checks tab after checks complete)
  • Tried Squashing the commits into one

@ritik307
Copy link
Contributor Author

@Shivansh2407 plz review this PR

ayan-biswas0412
ayan-biswas0412 suggested changes Mar 11, 2021
View reviewed changes
Copy link
Member

@ayan-biswas0412 ayan-biswas0412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bigger options with repeated strings I think I doesn't give a good visual aspect rather try to give some smaller options keeping the meaning same and I have also mentioned some of changes please change the question no 4 also in similar way and please insert another question such that Total number becomes 5

docs/seq-design/fsm.md Outdated
* Moore State Machine
* Both
* None
3. Finite State Machine is said to be `Mealy state machine`?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Finite State Machine is said to be `Mealy state machine`?
3. In `Mealy state machine` the outputs depends on ?

docs/seq-design/fsm.md Outdated
* Both
* None
3. Finite State Machine is said to be `Mealy state machine`?
1. Outputs depend on present inputs & present states.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Outputs depend on present inputs & present states.
1. on present inputs & present states.

docs/seq-design/fsm.md Outdated
* None
3. Finite State Machine is said to be `Mealy state machine`?
1. Outputs depend on present inputs & present states.
* Outputs depend only on present states.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Outputs depend only on present states.
* Only on present states.

docs/seq-design/fsm.md
3. Finite State Machine is said to be `Mealy state machine`?
1. Outputs depend on present inputs & present states.
* Outputs depend only on present states.
3. Finite State Machine is said to be `Moore state machine`?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make same changes Here also

@ritik307
Copy link
Contributor Author

@ayan-biswas0412 thanks for reviewing the code will do all the mentioned changes ASAP.

@Shivansh2407
Copy link
Member

Shivansh2407 commented Apr 5, 2021 •
edited

@ayan-biswas0412 thanks for reviewing the code will do all the mentioned changes ASAP.

@ritik307 could you please make the specified changes so that we can merge this PR. Thanks a lot! Also make sure to fix the conflicts 👍

@ritik307
Copy link
Contributor Author

ritik307 commented Apr 5, 2021

@Shivansh2407 Done! please review

ayan-biswas0412
ayan-biswas0412 suggested changes Apr 18, 2021
View reviewed changes
Copy link
Member

@ayan-biswas0412 ayan-biswas0412 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unnecessary spaces from the files in which you have changed nothing, resolve the conflicts first

@manjotsidhu manjotsidhu added the inactive inactive for a significant peiod, would be closed in near future label May 22, 2021
@manjotsidhu
Copy link
Member

Closing this Pull Request since it's not active. You can make a new Pull Request anytime with the changes. Thanks for the contribution.

@manjotsidhu manjotsidhu mentioned this pull request May 22, 2021
Closed
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayan-biswas0412 ayan-biswas0412 ayan-biswas0412 requested changes

Assignees
No one assigned
Labels
inactive inactive for a significant peiod, would be closed in near future
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

To add some new pop quizzes to the various topics in the book
4 participants
@ritik307 @Shivansh2407 @manjotsidhu @ayan-biswas0412