Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jquery removal from circuit.js #67

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GarvitSinghal47
Copy link
Contributor

Fixes #27

Describe the changes you have made in this PR - Removed jquery from the circuit.js file

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

@commit-lint
Copy link

commit-lint bot commented Jan 26, 2023

Bug Fixes

  • Jquery removal from circuit.js (7d1c09a)

Contributors

GarvitSinghal47

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@netlify
Copy link

netlify bot commented Jan 26, 2023

Deploy Preview for circuitverse ready!

Name Link
🔨 Latest commit 7d1c09a
🔍 Latest deploy log https://app.netlify.com/sites/circuitverse/deploys/63d2c74cedaab80009c4d8f9
😎 Deploy Preview https://deploy-preview-67--circuitverse.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@GarvitSinghal47 GarvitSinghal47 changed the title fix: Jquery removal from circuit.js fix: jquery removal from circuit.js Jan 26, 2023
@GarvitSinghal47
Copy link
Contributor Author

@devartstar getting duplication error for the code from codeclimate for circuit.js and listners.js , so should i leave this as it is or need to do something for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop JQuery dependency
1 participant