Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop JQuery dependency #27

Open
tachyons opened this issue Oct 12, 2022 · 14 comments · Fixed by #28, #29, #34, #35 or #193
Open

Drop JQuery dependency #27

tachyons opened this issue Oct 12, 2022 · 14 comments · Fixed by #28, #29, #34, #35 or #193

Comments

@tachyons
Copy link
Member

Though we removed jquery ui, we still have jquery in our codebase. which need to be removed and use native DOM methods

@disha1202
Copy link
Contributor

Hi @tachyons,
I would like to work on this.

@tachyons
Copy link
Member Author

@disha1202 You can start working on this, but since jquery is used in several files, PR will be very huge. So I suggest you create PRs with changes per file. Also multiple people can work on this if you cab mention which file/files you want to work on

@disha1202
Copy link
Contributor

Sure @tachyons, I would like to start with Verilog2CV.js file.

@snehalshah8429
Copy link

@tachyons I would like to contribute on this

@snehalshah8429
Copy link

@disha1202 do you need any help in this project?

@disha1202
Copy link
Contributor

@tachyons, I've removed JQuery dependency in Verilog2CV.js file.
Please take a look.

@GarvitSinghal47
Copy link
Contributor

@tachyons and @devartstar as there are multiple js files in which there is still jquery present in them I would like to work and help remove jquery from some of the files.

@GarvitSinghal47
Copy link
Contributor

Hey @tachyons as i discussed in the slack i am currently working on circuit.js file.

@niladrix719
Copy link
Member

niladrix719 commented Oct 24, 2023

i am working on actions.js

@antriksh-9
Copy link
Contributor

Hey @Arnabdaz @Prerna-0202 I have worked on PR #226.

@DhairyaMajmudar DhairyaMajmudar linked a pull request Dec 27, 2023 that will close this issue
@antriksh-9
Copy link
Contributor

I am working on testbench.js file.

@antriksh-9
Copy link
Contributor

antriksh-9 commented Dec 30, 2023

I am working on testCreator.js file.

@antriksh-9
Copy link
Contributor

I am working on canvasApi.js file.

@tachyons
Copy link
Member Author

tachyons commented Jan 9, 2024

Note: when you move transitions like fade from JQuery, use Vue transitions instead of trying to implement it vanilla JS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment