Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search circuit feature #225

Merged
merged 5 commits into from
Jun 29, 2022
Merged

Search circuit feature #225

merged 5 commits into from
Jun 29, 2022

Conversation

aman-singh7
Copy link
Member

Signed-off-by: Aman aman2@me.iitr.ac.in

Fixes #223

Describe the changes you have made in this PR -

Screenshots of the changes (If any) -

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Signed-off-by: Aman <aman2@me.iitr.ac.in>
Signed-off-by: Aman <aman2@me.iitr.ac.in>
@aman-singh7 aman-singh7 added the GSoC'22 Label for Google Summer of Code 2022 PR's and Issues related. label Jun 18, 2022
@aman-singh7 aman-singh7 self-assigned this Jun 18, 2022
Signed-off-by: Aman <aman2@me.iitr.ac.in>
@aman-singh7 aman-singh7 changed the title [WIP]: Search circuit feature Search circuit feature Jun 21, 2022
Signed-off-by: Aman <aman2@me.iitr.ac.in>
@aman-singh7 aman-singh7 marked this pull request as ready for review June 24, 2022 14:23
Signed-off-by: Aman <aman2@me.iitr.ac.in>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2560390265

  • 71 of 232 (30.6%) changed or added relevant lines in 8 files are covered.
  • 5 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-1.5%) to 69.091%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/ui/views/home/home_view.dart 0 2 0.0%
lib/ui/views/cv_landing_view.dart 11 15 73.33%
lib/services/API/projects_api.dart 0 11 0.0%
lib/ui/views/projects/featured_projects_view.dart 38 57 66.67%
lib/viewmodels/cv_landing_viewmodel.dart 1 20 5.0%
lib/viewmodels/projects/featured_projects_viewmodel.dart 16 50 32.0%
lib/ui/components/cv_drawer.dart 1 73 1.37%
Files with Coverage Reduction New Missed Lines %
lib/services/local_storage_service.dart 1 20.93%
lib/ui/views/cv_landing_view.dart 1 75.0%
lib/viewmodels/cv_landing_viewmodel.dart 1 7.32%
lib/cv_theme.dart 2 83.33%
Totals Coverage Status
Change from base Build 2487829593: -1.5%
Covered Lines: 3914
Relevant Lines: 5665

💛 - Coveralls

@manjotsidhu manjotsidhu merged commit caffe00 into master Jun 29, 2022
@manjotsidhu manjotsidhu deleted the search_circuit branch June 29, 2022 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC'22 Label for Google Summer of Code 2022 PR's and Issues related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search feature in Circuits
3 participants