Vibhi #49
Merged
Vibhi #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the dockerfile.
Updated the procedure in step.
minor edits
corrected the formatting issues.
Added description for COPY and chmod.
minor edits.
removed div
removed div
annegentle
suggested changes
Sep 16, 2020
labs/docker-101/1.md
Outdated
| @@ -2,7 +2,8 @@ | |||
|
|
|||
| ## Objective | |||
|
|
|||
| This Learning Lab introduces Docker, a tool suite for building, sharing, and deploying containers. For more information about containers, see the [Containers-101](https://developer.cisco.com/learning/lab/containers-101/step/1) Lab. Use this Learning Lab to build, deploy, and optionally share your first Docker container. | |||
| This Learning Lab introduces Docker, a tool suite for building, sharing, and deploying containers. Use this Learning Lab to build, deploy, and optionally share your first Docker container. For more information about containers, see the [Containers-101](https://developer.cisco.com/learning/lab/containers-101/step/1) Lab. | |||
| Further reading is available in the excellent docker introduction at [imapex.io](https://github.com/imapex-training/mod_adv_docker/blob/master/README.md). | |||
labs/docker-101/2.md
Outdated
| @@ -36,15 +36,15 @@ CMD ["/hello"] | |||
|
|
|||
| Here's what it tells `docker build` to do: | |||
|
|
|||
| `FROM scratch` | |||
| * `FROM scratch` | |||
There was a problem hiding this comment.
I'd remove the bullets - just in case it would cause confusion about what goes into the Dockerfile line-by-line.
| @@ -90,7 +90,7 @@ The example command downloads and runs the Ubuntu container from DockerHub. The | |||
|
|
|||
|  | |||
|
|
|||
| # Testing Isolation. | |||
| # Testing Isolation | |||
labs/docker-101/3.md
Outdated
| @@ -2,131 +2,126 @@ | |||
|
|
|||
| Next we'll build our own Ubuntu Docker image instead of using the one from DockerHub. | |||
|
|
|||
| 1. __Download the files__. Begin by downloading the Ubuntu Dockerfile and its dependencies. | |||
| 1. Downloading the Ubuntu Dockerfile and its dependencies. | |||
labs/docker-101/3.md
Outdated
|  | ||
|
|
||
| 5. __Run the new image__. Run the newly created docker image by giving the randomly-chosen ID to Docker: | ||
| 5. Run the newly created docker image by giving the randomly-chosen ID to Docker: |
labs/docker-101/3.md
Outdated
| ``` | ||
| docker build . | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Tell them to make note of the container ID that is returned once the build is done.
| terminal. | ||
| ``` | ||
| docker run <Container ID> | ||
| ``` |
There was a problem hiding this comment.
Maybe tell them where to get the Container ID here also.
labs/docker-101/3.md
Outdated
| ``` | ||
| The "Hello from DevNet!" message is displayed in the container terminal. | ||
|
|
||
|  | ||
|
|
||
| Congratulations, you've just built and run a custom docker image! |
labs/docker-101/4.md
Outdated
| A Docker container image can run any application you like. Let's build | ||
| one that runs a web server. The web server will run whenever the | ||
| container image starts up. | ||
| A Docker container image can run any application you like. Let's build one that runs a web server. The web server will run whenever the container image starts up. | ||
|
|
||
| The following python command creates and starts a simple web server: |
| ``` | ||
| docker inspect <container ID> | ||
| ``` | ||
| Running this command displays a great deal of information about the container. Included in the output is the container's address, identified as "IPAddress". |
There was a problem hiding this comment.
Probably need to tell them how to get the container ID, by running docker ps.
There was a problem hiding this comment.
Updated all the review comments. Kindly review...
Changed docker to Docker.
updated the review comments.
Updated the review comments.
updated the review comments.
updated the review comments
annegentle
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Anne,
Based on your updates in the Docker file, I have updated the "Building a Custom Cisco Learning Labs Container" section.
Corrected the byod.html.
Performed editorial review of this Lab.
Kindly review the updates and provide your comments.
Regards,
Vibhinna