Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing changes from Bitbucket #11

Merged
merged 2 commits into from
May 18, 2021
Merged

Missing changes from Bitbucket #11

merged 2 commits into from
May 18, 2021

Conversation

rschmied
Copy link
Member

@rschmied rschmied commented May 18, 2021

  • added requests-toolbelt (missing dependency),
    resolves requests_toolbelt is required #10
  • also added pytest configuration files
  • added fixtures for tests to pass
  • added tests which were missing from Bitbucket
  • applied black formatting
  • GitHub test automation
  • assure 3.5 compatibility
  • remove hashes from requirements.txt

@rschmied rschmied force-pushed the dev branch 2 times, most recently from a317d34 to 2617435 Compare May 18, 2021 10:05
Copy link
Member Author

@rschmied rschmied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add @xorrkaz as a reviewer

@xorrkaz
Copy link
Collaborator

xorrkaz commented May 18, 2021

Looks good to me. Could we also add 3.9 to the supported Python list?

Copy link
Collaborator

@xorrkaz xorrkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the Python add.

- added requests-toolbelt (missing dependency),
  resolves #10
- also added pytest configuration files
- added fixtures for tests to pass
- added tests which were missing from Bitbucket
- applied black formatting
- GitHub test automation
- assure 3.5 compatibility
- remove hashes from requirements.txt
@xorrkaz
Copy link
Collaborator

xorrkaz commented May 18, 2021

Why pull out Python 3.9 now?

@rschmied rschmied merged commit 30b4cae into master May 18, 2021
@rschmied
Copy link
Member Author

I've merged this now -- I'm still not sure why the "action workflows" fail even though they do pass locally. Maybe it's a resource issue (e.g. running out of minutes or something). I wish there would be better indication of why things get cancelled instead of simply cancelling all workflows with no obvious reason.

rschmied pushed a commit that referenced this pull request Jul 18, 2022
…ython-description-of-data-model to dev

* commit '92d57a38041821864d03d99059ed164747e03b6d':
  small updates to group api tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

requests_toolbelt is required
2 participants