-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing changes from Bitbucket #11
Conversation
a317d34
to
2617435
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to add @xorrkaz as a reviewer
Looks good to me. Could we also add 3.9 to the supported Python list? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the Python add.
- added requests-toolbelt (missing dependency), resolves #10 - also added pytest configuration files - added fixtures for tests to pass - added tests which were missing from Bitbucket - applied black formatting - GitHub test automation - assure 3.5 compatibility - remove hashes from requirements.txt
Why pull out Python 3.9 now? |
I've merged this now -- I'm still not sure why the "action workflows" fail even though they do pass locally. Maybe it's a resource issue (e.g. running out of minutes or something). I wish there would be better indication of why things get cancelled instead of simply cancelling all workflows with no obvious reason. |
…ython-description-of-data-model to dev * commit '92d57a38041821864d03d99059ed164747e03b6d': small updates to group api tests
resolves requests_toolbelt is required #10