fixed an issue where ShowIpRoute for iosxe would not parse nat_dia routes of type n and Nd, which would throw an error #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utes of type n and Nd, which would throw an error
Taarini
approved these changes
Nov 29, 2022
ketulsuthar
approved these changes
Dec 20, 2022
|
Hi @fiblund, Can you please merge the master with your branch, then it is good to merge |
|
Hi Taarini,
Must’ve missed your email – Not really seeing any options to complete the merge, but I might just be missing something?
***@***.***
Not really 100% sure how to do it to be honest ☹
/Frederik
From: Taarini ***@***.***>
Date: Friday, 6 January 2023 at 19.53
To: CiscoTestAutomation/genieparser ***@***.***>
Cc: Frederik Fibiger-Lundberg ***@***.***>, Mention ***@***.***>
Subject: Re: [CiscoTestAutomation/genieparser] fixed an issue where ShowIpRoute for iosxe would not parse nat_dia routes of type n and Nd, which would throw an error (PR #715)
Hi @fiblund<https://github.com/fiblund>,
Can you please merge the master with your branch, then it is good to merge
—
Reply to this email directly, view it on GitHub<#715 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AI3523A3F475COYLKHAF65TWRBS4BANCNFSM6AAAAAASNMAJUM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the following line to iosxe/show_routing.py parser
source_protocol_dict['nat_dia'] = ['n', 'Nd']
Motivation and Context
Related to issue CiscoTestAutomation/pyats#190.
It fixes an issue where ShowIpRoute for iosxe would not parse nat dia routes of the type n and Nd
Impact (If any)
No negative impact - Tests passed succesfully.
Screenshots:
Full output from test
➜ tests git:(master) ✗ python3 folder_parsing_job.py -o iosxe -c ShowIpRoute
2022-11-28T14:54:50: %AETEST-INFO: +------------------------------------------------------------------------------+
2022-11-28T14:54:50: %AETEST-INFO: | Starting testcase SuperFileBasedTesting |
2022-11-28T14:54:50: %AETEST-INFO: +------------------------------------------------------------------------------+
2022-11-28T14:54:50: %AETEST-INFO: +------------------------------------------------------------------------------+
2022-11-28T14:54:50: %AETEST-INFO: | Starting section setup |
2022-11-28T14:54:50: %AETEST-INFO: +------------------------------------------------------------------------------+
2022-11-28T14:54:50: %AETEST-INFO: The result of section setup is => PASSED
2022-11-28T14:54:50: %AETEST-INFO: The result of testcase SuperFileBasedTesting is => PASSED
2022-11-28T14:54:50: %AETEST-INFO: +------------------------------------------------------------------------------+
2022-11-28T14:54:50: %AETEST-INFO: | Starting testcase iosxe |
2022-11-28T14:54:50: %AETEST-INFO: +------------------------------------------------------------------------------+
2022-11-28T14:54:50: %AETEST-INFO: +------------------------------------------------------------------------------+
2022-11-28T14:54:50: %AETEST-INFO: | Starting section setup |
2022-11-28T14:54:50: %AETEST-INFO: +------------------------------------------------------------------------------+
2022-11-28T14:54:50: %AETEST-INFO: The result of section setup is => PASSED
2022-11-28T14:54:50: %AETEST-INFO: +------------------------------------------------------------------------------+
2022-11-28T14:54:50: %AETEST-INFO: | Starting section ShowIpRoute |
2022-11-28T14:54:50: %AETEST-INFO: +------------------------------------------------------------------------------+
2022-11-28T14:54:50: %AETEST-INFO: +..............................................................................+
2022-11-28T14:54:50: %AETEST-INFO: : Starting STEP 1: iosxe -> ShowIpRoute :
2022-11-28T14:54:50: %AETEST-INFO: +..............................................................................+
2022-11-28T14:54:50: %AETEST-INFO: +..............................................................................+
2022-11-28T14:54:50: %AETEST-INFO: : Starting STEP 1.1: Test Golden -> iosxe -> ShowIpRoute :
2022-11-28T14:54:50: %AETEST-INFO: +..............................................................................+
2022-11-28T14:54:50: %AETEST-INFO: +..............................................................................+
2022-11-28T14:54:50: %AETEST-INFO: : Starting STEP 1.1.1: Gold -> iosxe -> ShowIpRoute -> golden_output1 :
2022-11-28T14:54:50: %AETEST-INFO: +..............................................................................+
2022-11-28T14:54:50: %AETEST-INFO: The result of STEP 1.1.1: Gold -> iosxe -> ShowIpRoute -> golden_output1 is => PASSED
2022-11-28T14:54:50: %AETEST-INFO: +..............................................................................+
2022-11-28T14:54:50: %AETEST-INFO: : Starting STEP 1.1.2: Gold -> iosxe -> ShowIpRoute -> golden_output2 :
2022-11-28T14:54:50: %AETEST-INFO: +..............................................................................+
2022-11-28T14:54:50: %AETEST-INFO: The result of STEP 1.1.2: Gold -> iosxe -> ShowIpRoute -> golden_output2 is => PASSED
2022-11-28T14:54:50: %AETEST-INFO: +..............................................................................+
2022-11-28T14:54:50: %AETEST-INFO: : Starting STEP 1.1.3: Gold -> iosxe -> ShowIpRoute -> golden_output3 :
2022-11-28T14:54:50: %AETEST-INFO: +..............................................................................+
2022-11-28T14:54:50: %AETEST-INFO: The result of STEP 1.1.3: Gold -> iosxe -> ShowIpRoute -> golden_output3 is => PASSED
2022-11-28T14:54:50: %AETEST-INFO: +..............................................................................+
2022-11-28T14:54:50: %AETEST-INFO: : Starting STEP 1.1.4: Gold -> iosxe -> ShowIpRoute -> golden_output4 :
2022-11-28T14:54:50: %AETEST-INFO: +..............................................................................+
2022-11-28T14:54:50: %AETEST-INFO: The result of STEP 1.1.4: Gold -> iosxe -> ShowIpRoute -> golden_output4 is => PASSED
2022-11-28T14:54:50: %AETEST-INFO: +..............................................................................+
2022-11-28T14:54:50: %AETEST-INFO: : Starting STEP 1.1.5: Gold -> iosxe -> ShowIpRoute -> golden_output5 :
2022-11-28T14:54:50: %AETEST-INFO: +..............................................................................+
2022-11-28T14:54:50: %AETEST-INFO: The result of STEP 1.1.5: Gold -> iosxe -> ShowIpRoute -> golden_output5 is => PASSED
2022-11-28T14:54:50: %AETEST-INFO: +..............................................................................+
2022-11-28T14:54:50: %AETEST-INFO: : Starting STEP 1.1.6: Gold -> iosxe -> ShowIpRoute -> golden_output6 :
2022-11-28T14:54:50: %AETEST-INFO: +..............................................................................+
2022-11-28T14:54:50: %AETEST-INFO: The result of STEP 1.1.6: Gold -> iosxe -> ShowIpRoute -> golden_output6 is => PASSED
2022-11-28T14:54:50: %AETEST-INFO: +..............................................................................+
2022-11-28T14:54:50: %AETEST-INFO: : Starting STEP 1.1.7: Gold -> iosxe -> ShowIpRoute -> golden_output7 :
2022-11-28T14:54:50: %AETEST-INFO: +..............................................................................+
2022-11-28T14:54:50: %AETEST-INFO: The result of STEP 1.1.7: Gold -> iosxe -> ShowIpRoute -> golden_output7 is => PASSED
2022-11-28T14:54:50: %AETEST-INFO: +..............................................................................+
2022-11-28T14:54:50: %AETEST-INFO: : Starting STEP 1.1.8: Gold -> iosxe -> ShowIpRoute -> golden_output8 :
2022-11-28T14:54:50: %AETEST-INFO: +..............................................................................+
2022-11-28T14:54:50: %AETEST-INFO: The result of STEP 1.1.8: Gold -> iosxe -> ShowIpRoute -> golden_output8 is => PASSED
2022-11-28T14:54:50: %AETEST-INFO: +..............................................................................+
2022-11-28T14:54:50: %AETEST-INFO: : Starting STEP 1.1.9: Gold -> iosxe -> ShowIpRoute -> golden_output11 :
2022-11-28T14:54:50: %AETEST-INFO: +..............................................................................+
2022-11-28T14:54:50: %AETEST-INFO: The result of STEP 1.1.9: Gold -> iosxe -> ShowIpRoute -> golden_output11 is => PASSED
2022-11-28T14:54:50: %AETEST-INFO: The result of STEP 1.1: Test Golden -> iosxe -> ShowIpRoute is => PASSED
2022-11-28T14:54:50: %AETEST-INFO: +..............................................................................+
2022-11-28T14:54:50: %AETEST-INFO: : Starting STEP 1.2: Test Empty -> iosxe -> ShowIpRoute :
2022-11-28T14:54:50: %AETEST-INFO: +..............................................................................+
2022-11-28T14:54:50: %AETEST-INFO: +..............................................................................+
2022-11-28T14:54:50: %AETEST-INFO: : Starting STEP 1.2.1: Empty -> iosxe -> ShowIpRoute -> empty_output :
2022-11-28T14:54:50: %AETEST-INFO: +..............................................................................+
2022-11-28T14:54:50: %AETEST-INFO: The result of STEP 1.2.1: Empty -> iosxe -> ShowIpRoute -> empty_output is => PASSED
2022-11-28T14:54:50: %AETEST-INFO: The result of STEP 1.2: Test Empty -> iosxe -> ShowIpRoute is => PASSED
2022-11-28T14:54:50: %AETEST-INFO: The result of STEP 1: iosxe -> ShowIpRoute is => PASSED
2022-11-28T14:54:50: %AETEST-INFO: +..........................................................+
2022-11-28T14:54:50: %AETEST-INFO: : STEPS Report :
2022-11-28T14:54:50: %AETEST-INFO: +..........................................................+
2022-11-28T14:54:50: %AETEST-INFO: STEP 1 - iosxe -> ShowIpRoute Passed
2022-11-28T14:54:50: %AETEST-INFO: STEP 1.1 - Test Golden -> iosxe -> ShowIpRoute Passed
2022-11-28T14:54:50: %AETEST-INFO: STEP 1.1.1 - Gold -> iosxe -> ShowIpRoute -> golden_output1Passed
2022-11-28T14:54:50: %AETEST-INFO: STEP 1.1.2 - Gold -> iosxe -> ShowIpRoute -> golden_output2Passed
2022-11-28T14:54:50: %AETEST-INFO: STEP 1.1.3 - Gold -> iosxe -> ShowIpRoute -> golden_output3Passed
2022-11-28T14:54:50: %AETEST-INFO: STEP 1.1.4 - Gold -> iosxe -> ShowIpRoute -> golden_output4Passed
2022-11-28T14:54:50: %AETEST-INFO: STEP 1.1.5 - Gold -> iosxe -> ShowIpRoute -> golden_output5Passed
2022-11-28T14:54:50: %AETEST-INFO: STEP 1.1.6 - Gold -> iosxe -> ShowIpRoute -> golden_output6Passed
2022-11-28T14:54:50: %AETEST-INFO: STEP 1.1.7 - Gold -> iosxe -> ShowIpRoute -> golden_output7Passed
2022-11-28T14:54:50: %AETEST-INFO: STEP 1.1.8 - Gold -> iosxe -> ShowIpRoute -> golden_output8Passed
2022-11-28T14:54:50: %AETEST-INFO: STEP 1.1.9 - Gold -> iosxe -> ShowIpRoute -> golden_output11Passed
2022-11-28T14:54:50: %AETEST-INFO: STEP 1.2 - Test Empty -> iosxe -> ShowIpRoute Passed
2022-11-28T14:54:50: %AETEST-INFO: STEP 1.2.1 - Empty -> iosxe -> ShowIpRoute -> empty_outputPassed
2022-11-28T14:54:50: %AETEST-INFO: ............................................................
2022-11-28T14:54:50: %AETEST-INFO: The result of section ShowIpRoute is => PASSED
2022-11-28T14:54:50: %AETEST-INFO: +------------------------------------------------------------------------------+
2022-11-28T14:54:50: %AETEST-INFO: | Starting section cleanup |
2022-11-28T14:54:50: %AETEST-INFO: +------------------------------------------------------------------------------+
2022-11-28T14:54:50: %AETEST-INFO: The result of section cleanup is => PASSED
2022-11-28T14:54:50: %AETEST-INFO: The result of testcase iosxe is => PASSED
2022-11-28T14:54:50: %GENIE-INFO: +------------------------------------------------------------------------------+
2022-11-28T14:54:50: %GENIE-INFO: | Unittest results |
2022-11-28T14:54:50: %GENIE-INFO: +------------------------------------------------------------------------------+
2022-11-28T14:54:50: %GENIE-INFO: SECTIONS/TESTCASES RESULT
2022-11-28T14:54:50: %GENIE-INFO: --------------------------------------------------------------------------------
2022-11-28T14:54:50: %GENIE-INFO: .
2022-11-28T14:54:50: %GENIE-INFO: |-- SuperFileBasedTesting PASSED
2022-11-28T14:54:50: %GENIE-INFO: |
-- setup PASSED 2022-11-28T14:54:50: %GENIE-INFO:-- iosxe PASSED2022-11-28T14:54:50: %GENIE-INFO: |-- setup PASSED
2022-11-28T14:54:50: %GENIE-INFO: |-- ShowIpRoute PASSED
2022-11-28T14:54:50: %GENIE-INFO: | |-- Step 1: iosxe -> ShowIpRoute PASSED
2022-11-28T14:54:50: %GENIE-INFO: | |-- Step 1.1: Test Golden -> iosxe -> ShowIpRoute PASSED
2022-11-28T14:54:50: %GENIE-INFO: | |-- Step 1.1.1: Gold -> iosxe -> ShowIpRoute -> golden_output1 PASSED
2022-11-28T14:54:50: %GENIE-INFO: | |-- Step 1.1.2: Gold -> iosxe -> ShowIpRoute -> golden_output2 PASSED
2022-11-28T14:54:50: %GENIE-INFO: | |-- Step 1.1.3: Gold -> iosxe -> ShowIpRoute -> golden_output3 PASSED
2022-11-28T14:54:50: %GENIE-INFO: | |-- Step 1.1.4: Gold -> iosxe -> ShowIpRoute -> golden_output4 PASSED
2022-11-28T14:54:50: %GENIE-INFO: | |-- Step 1.1.5: Gold -> iosxe -> ShowIpRoute -> golden_output5 PASSED
2022-11-28T14:54:50: %GENIE-INFO: | |-- Step 1.1.6: Gold -> iosxe -> ShowIpRoute -> golden_output6 PASSED
2022-11-28T14:54:50: %GENIE-INFO: | |-- Step 1.1.7: Gold -> iosxe -> ShowIpRoute -> golden_output7 PASSED
2022-11-28T14:54:50: %GENIE-INFO: | |-- Step 1.1.8: Gold -> iosxe -> ShowIpRoute -> golden_output8 PASSED
2022-11-28T14:54:50: %GENIE-INFO: | |-- Step 1.1.9: Gold -> iosxe -> ShowIpRoute -> golden_outp... PASSED
2022-11-28T14:54:50: %GENIE-INFO: | |-- Step 1.2: Test Empty -> iosxe -> ShowIpRoute PASSED
2022-11-28T14:54:50: %GENIE-INFO: |
-- Step 1.2.1: Empty -> iosxe -> ShowIpRoute -> empty_output PASSED 2022-11-28T14:54:50: %GENIE-INFO:-- cleanup PASSED2022-11-28T14:54:50: %GENIE-INFO: +------------------------------------------------------------------------------+
2022-11-28T14:54:50: %GENIE-INFO: | Summary |
2022-11-28T14:54:50: %GENIE-INFO: +------------------------------------------------------------------------------+
2022-11-28T14:54:50: %GENIE-INFO: Number of ABORTED 0
2022-11-28T14:54:50: %GENIE-INFO: Number of BLOCKED 0
2022-11-28T14:54:50: %GENIE-INFO: Number of ERRORED 0
2022-11-28T14:54:50: %GENIE-INFO: Number of FAILED 0
2022-11-28T14:54:50: %GENIE-INFO: Number of PASSED 2
2022-11-28T14:54:50: %GENIE-INFO: Number of PASSX 0
2022-11-28T14:54:50: %GENIE-INFO: Number of SKIPPED 0
2022-11-28T14:54:50: %GENIE-INFO: Total Number 2
2022-11-28T14:54:50: %GENIE-INFO: Success Rate 100.0%
2022-11-28T14:54:50: %GENIE-INFO: --------------------------------------------------------------------------------
2022-11-28T14:54:50: %GENIE-INFO: Total Passing Unittests 10
2022-11-28T14:54:50: %GENIE-INFO: Total Failed Unittests 0
2022-11-28T14:54:50: %GENIE-INFO: Total Errored Unittests 0
2022-11-28T14:54:50: %GENIE-INFO: Total Unittests 10
2022-11-28T14:54:50: %GENIE-INFO: --------------------------------------------------------------------------------
Checklist: