Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sablier support for streams creation #11

Merged
merged 7 commits into from
May 9, 2022
Merged

Add sablier support for streams creation #11

merged 7 commits into from
May 9, 2022

Conversation

petrovska-petro
Copy link

@petrovska-petro petrovska-petro commented May 4, 2022

Tackles #10

brownie run sablier/create_streams

brownie run sablier/cancel_stream main 1500

Copy link
Collaborator

@gosuto-inzasheru gosuto-inzasheru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing file i think in your commit:

AttributeError: 'GreatApeSafe' object has no attribute 'init_sablier'

also i suggest we add a cancel_stream method, and try to create at least one stream on rinkeby, withdraw from it and then cancel it.

great_ape_safe/ape_api/sablier.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@gosuto-inzasheru gosuto-inzasheru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was all tested successfully on rinkeby

@petrovska-petro petrovska-petro merged commit 2c907ff into main May 9, 2022
@petrovska-petro petrovska-petro deleted the issue/10 branch May 9, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants