Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Russian translation update #207

Closed
originalfoo opened this issue Mar 3, 2019 · 5 comments
Closed

Russian translation update #207

originalfoo opened this issue Mar 3, 2019 · 5 comments
Assignees
Labels
enhancement Improve existing feature LABS TM:PE LABS branch Localisation Localised text and features STABLE TM:PE STABLE branch Usability Make mod easier to use
Milestone

Comments

@originalfoo
Copy link
Member

vitalii201 (steam user): Still a little translation fix
https://pastebin.com/bjRxGkgg

It's possible he also sent PR to old repo? I've not had any notifications (and am contrib on that repo) so possibly not. Anyway, the patebin seems to contain the full locale file.

@originalfoo originalfoo added enhancement Improve existing feature Usability Make mod easier to use Localisation Localised text and features LABS TM:PE LABS branch STABLE TM:PE STABLE branch labels Mar 3, 2019
@VictorPhilipp VictorPhilipp modified the milestones: 1.10.15-stable, 1.10.17 Mar 4, 2019
@VictorPhilipp
Copy link
Collaborator

Side note: Can we have multiple milestones for the same issue? We have to synchronize versions...

@originalfoo originalfoo modified the milestones: 1.10.15-stable, 1.10.17 Mar 4, 2019
@originalfoo
Copy link
Member Author

Side note...

Not that I'm aware of - github only allows one milestone :/

Looks like we'll need multiple issues for things like this which is a bit of a PITA.

@VictorPhilipp
Copy link
Collaborator

VictorPhilipp commented Mar 5, 2019

(off-topic)

  1. We could represent milestones with labels.
  2. We could enforce a strict transition scheme from labs to stable where each labs version must become stable at some time (though this would limit our abilities (which is not always a bad thing))

@VictorPhilipp VictorPhilipp self-assigned this Mar 5, 2019
@VictorPhilipp
Copy link
Collaborator

Fixed in 1.10.15-stable.
Update for 1.10.17-labs pending.

@originalfoo
Copy link
Member Author

(off-topic)

After stable reaches parity with labs, we can then do the strict labs -> stable thing.

I'm not sure using labels for milestones will work out well. We'd just end up with loads of crufty labels, and the milestones view would get confusing too.

Ultimately I think we'll end up doing work against a labs milestone, and then once it's tested in labs we update the issue to use a stable milestone. So issue stays open to remind us that there's something that needs porting to stable.

This is probably best discussed in the developer discord chat or a separate issue ticket.

krzychu124 added a commit that referenced this issue Mar 6, 2019
@VictorPhilipp VictorPhilipp modified the milestones: 1.10.15-stable, 1.10.17 Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing feature LABS TM:PE LABS branch Localisation Localised text and features STABLE TM:PE STABLE branch Usability Make mod easier to use
Projects
None yet
Development

No branches or pull requests

2 participants